Differential D33367

bbr: drop packet synchronously in ctf_do_dropwithreset_conn()
ClosedPublic
Actions

Authored by glebius on Dec 10 2021, 2:47 AM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG17ac6b1c1407: bbr: drop packet synchronously in ctf_do_dropwithreset_conn()

Summary

This function is always called from tcp_do_segment() method, that
can drop tcpcb and return unlocked.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43273
Build 40161: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 10 2021, 2:47 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 10 2021, 2:47 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 10 2021, 2:47 AM

Harbormaster completed remote builds in B43273: Diff 99808.Dec 10 2021, 2:47 AM

glebius added a parent revision: D33366: tcp: mechanically substitute call to tfb_tcp_output to new method..Dec 10 2021, 2:47 AM

glebius added a child revision: D33368: rack: drop connection synchronously, when we can.

You might want to check what rrs@ thinks...

This revision is now accepted and ready to land.Dec 10 2021, 12:03 PM

Fix a bug, rebase, update descr.

This revision now requires review to proceed.Dec 13 2021, 6:14 PM

Harbormaster completed remote builds in B43316: Diff 99949.Dec 13 2021, 6:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2021, 4:50 PM

Closed by commit rG17ac6b1c1407: bbr: drop packet synchronously in ctf_do_dropwithreset_conn() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG17ac6b1c1407: bbr: drop packet synchronously in ctf_do_dropwithreset_conn().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack_bbr_common.c

7 lines

Diff 99808

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

bbr: drop packet synchronously in ctf_do_dropwithreset_conn()ClosedPublicActions