Page MenuHomeFreeBSD
Differential D33333

bhyve: add support for MTRR
ClosedPublic
Actions

Authored by corvink on Dec 8 2021, 12:01 PM.
Tags
Referenced Files
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:43 AM
Unknown Object (File)
Sat, Nov 2, 4:43 AM
Unknown Object (File)
Sat, Nov 2, 4:43 AM
Unknown Object (File)
Sat, Nov 2, 4:43 AM
Unknown Object (File)
Sat, Nov 2, 4:23 AM
Unknown Object (File)
Mon, Oct 28, 9:43 AM
Unknown Object (File)
Mon, Oct 28, 6:42 AM
View All 50 Files
Subscribers
bcran
emaste
imp
rgrimes
bhyve

Details

Reviewers
manu
markj
jhb
Group Reviewers
bhyve
Commits
rG24100ad5de39: bhyve: add support for MTRR
rG6171e026be11: bhyve: add support for MTRR
Summary

Some guests or driver might depend on MTRR to work properly. E.g. the
nvidia gpu driver won't work without MTRR.

Note:
I've only tested this patch on an Intel system.

The patch is also published on https://github.com/Beckhoff/freebsd-src/commits/phab/corvink/mtrr.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

corvink created this revision.Dec 8 2021, 12:01 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptDec 8 2021, 12:01 PM
corvink requested review of this revision.Dec 8 2021, 12:01 PM
corvink edited the summary of this revision. (Show Details)Dec 8 2021, 12:06 PM
markj added inline comments.Dec 9 2021, 4:08 PM
sys/amd64/vmm/x86.c
672

This isn't right, there is one field for each variable range, but there are two registers associated with each range, base and mask.

emaste added a subscriber: emaste.Dec 10 2021, 6:11 PM
corvink updated this revision to Diff 100962.Jan 5 2022, 9:51 AM
  • add base and mask register for variable ranges
corvink marked an inline comment as done.Jan 5 2022, 9:52 AM
corvink added inline comments.
sys/amd64/vmm/x86.c
672

Sry for my late update. Thanks for catching this.

markj added inline comments.Jan 5 2022, 3:17 PM
sys/amd64/vmm/x86.c
672

Why uint64_t? num is a u_int.

690

Which MSRs is this comment referring to?

corvink updated this revision to Diff 101039.Jan 6 2022, 7:10 AM
corvink marked an inline comment as done.
  • fix type of MTRR offset
  • handle writes to reserved fields
corvink marked 2 inline comments as done.Jan 6 2022, 7:12 AM
corvink added inline comments.
sys/amd64/vmm/x86.c
690

Reserved fields should be checked for each MSR. I've added a check for it to all MSRs now.

markj accepted this revision as: markj.Jan 7 2022, 3:36 PM
markj added inline comments.
sys/amd64/vmm/x86.c
699

def_type will be 0 by default, it looks like at least FreeBSD's MTRR driver expects the "enabled" and "fixed-enabled" bits to be set by the BIOS. I guess it's ok to leave those bits off though...

This revision is now accepted and ready to land.Jan 7 2022, 3:36 PM
Closed by commit rG6171e026be11: bhyve: add support for MTRR (authored by corvink, committed by manu). · Explain WhyJan 14 2022, 11:43 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG6171e026be11: bhyve: add support for MTRR.
manu added a commit: rG24100ad5de39: bhyve: add support for MTRR.Jan 28 2022, 10:35 AM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
amd/
16 lines
3 lines
intel/
2 lines
17 lines
20 lines
82 lines

Diff 101039

View Options

sys/amd64/vmm/amd/svm_msr.c

Loading...
View Options

sys/amd64/vmm/amd/svm_softc.h

Loading...
View Options

sys/amd64/vmm/intel/vmx.h

Loading...
View Options

sys/amd64/vmm/intel/vmx_msr.c

Loading...
View Options

sys/amd64/vmm/x86.h

Loading...
View Options

sys/amd64/vmm/x86.c

Loading...