Page MenuHomeFreeBSD

bsdinstall: bootconfig: Try to clean old efi boot entries
ClosedPublic

Authored by manu on Dec 8 2021, 9:41 AM.
Tags
None
Referenced Files
F95773419: D33330.diff
Sun, Sep 22, 1:59 PM
Unknown Object (File)
Sat, Sep 21, 10:40 PM
Unknown Object (File)
Wed, Sep 18, 10:09 PM
Unknown Object (File)
Wed, Sep 18, 1:58 AM
Unknown Object (File)
Fri, Sep 13, 9:46 AM
Unknown Object (File)
Thu, Sep 12, 10:06 PM
Unknown Object (File)
Sun, Sep 8, 11:03 PM
Unknown Object (File)
Sat, Sep 7, 9:10 AM

Details

Summary

If one install FreeBSD on the same machine multiple times in a row or
on different harddrive they have a lot of 'FreeBSD' efi boot entries added.
With this patch we now do :

  • If there is no 'FreeBSD' entry we add one like before
  • If there is one or more entries we ask the user if they want to delete them all and add a new one
    • If they say yes we do that
    • If they say no we prompt them an inputbox so they can enter a different entry name if they want, it defaults to 'FreeBSD'

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43226
Build 40114: arc lint + arc unit

Event Timeline

manu requested review of this revision.Dec 8 2021, 9:41 AM
bapt requested changes to this revision.Dec 8 2021, 9:45 AM
bapt added a subscriber: bapt.
bapt added inline comments.
usr.sbin/bsdinstall/scripts/bootconfig
68

efibootmgr | grep -c 'FreeBSD$'

76

$DIALOG ?

This revision now requires changes to proceed.Dec 8 2021, 9:45 AM

Address bapt's comments.

manu marked 2 inline comments as done.Dec 8 2021, 9:50 AM
This revision is now accepted and ready to land.Dec 8 2021, 9:50 AM

This ticks all my boxes. It's optional, it prompts the user, and it appears to do the right sort of things to manage the list.