Page MenuHomeFreeBSD

Set as notyet few functions that are not used yet.
ClosedPublic

Authored by araujo on Aug 7 2015, 7:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 1:45 PM
Unknown Object (File)
Sat, Nov 9, 9:03 AM
Unknown Object (File)
Sat, Nov 9, 4:30 AM
Unknown Object (File)
Fri, Nov 8, 7:23 PM
Unknown Object (File)
Fri, Nov 8, 4:23 PM
Unknown Object (File)
Fri, Nov 8, 3:58 PM
Unknown Object (File)
Fri, Nov 8, 12:37 PM
Unknown Object (File)
Fri, Nov 8, 11:40 AM
Subscribers

Details

Summary
  • Wrap some unused functions with notyet.
  • Remove a dead MALLOC_DEFINE.
  • Set struct ctl_softc as static.
Test Plan

Example:
araujo@coxinha:/usr/src/sys/modules/ctl# make
Warning: Object directory not changed from original /usr/src/sys/modules/ctl
machine -> /usr/src/sys/amd64/include
x86 -> /usr/src/sys/x86/include
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -p
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -q
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -h
:> opt_cam.h
cc -O2 -pipe -Wmissing-variable-declarations -Wimplicit-function-declaration -Wunused-value -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys/modules/ctl/../.. -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -Dprintf=freebsd_kprintf -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -mno-aes -mno-avx -std=iso9899:1999 -c /usr/src/sys/modules/ctl/../../cam/ctl/ctl.c -o ctl.o
/usr/src/sys/modules/ctl/../../cam/ctl/ctl.c:14359:32: error: unused variable 'ctl_ha_component_ctlisc' [-Werror,-Wunused-variable]
static struct ctl_ha_component ctl_ha_component_ctlisc =

^

1 error generated.

  • Error code 1

After the patch, I can build without problem.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7
Build 7: arc lint + arc unit

Event Timeline

araujo retitled this revision from to Set as notyet few functions that are not used yet..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added reviewers: mav, bapt, rodrigc.

While theoretically control_softc should be static and passed through arguments, it is still used directly in other files.

araujo edited edge metadata.

Don't set control_softc as static, not now.
Thanks @mav.

mav edited edge metadata.

I have no objections.

This revision is now accepted and ready to land.Aug 7 2015, 8:22 AM