- Wrap some unused functions with notyet.
- Remove a dead MALLOC_DEFINE.
- Set struct ctl_softc as static.
Details
Example:
araujo@coxinha:/usr/src/sys/modules/ctl# make
Warning: Object directory not changed from original /usr/src/sys/modules/ctl
machine -> /usr/src/sys/amd64/include
x86 -> /usr/src/sys/x86/include
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -p
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -q
awk -f /usr/src/sys/modules/ctl/../../tools/vnode_if.awk /usr/src/sys/modules/ctl/../../kern/vnode_if.src -h
:> opt_cam.h
cc -O2 -pipe -Wmissing-variable-declarations -Wimplicit-function-declaration -Wunused-value -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/usr/src/sys/modules/ctl/../.. -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -Dprintf=freebsd_kprintf -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -mno-aes -mno-avx -std=iso9899:1999 -c /usr/src/sys/modules/ctl/../../cam/ctl/ctl.c -o ctl.o
/usr/src/sys/modules/ctl/../../cam/ctl/ctl.c:14359:32: error: unused variable 'ctl_ha_component_ctlisc' [-Werror,-Wunused-variable]
static struct ctl_ha_component ctl_ha_component_ctlisc =
^
1 error generated.
- Error code 1
After the patch, I can build without problem.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 7 Build 7: arc lint + arc unit
Event Timeline
While theoretically control_softc should be static and passed through arguments, it is still used directly in other files.