ifnet: allocate index at the end of if_alloc_domain()
ClosedPublic
Actions

Authored by glebius on Dec 4 2021, 9:13 PM.

Details

Reviewers

bz
kp

Group Reviewers

network

Commits

rG7afcdd13a49c: ifnet: allocate index at the end of if_alloc_domain()
rG8062e5759cb4: ifnet: allocate index at the end of if_alloc_domain()

Summary

Now that if_alloc_domain() never fails and actually doesn't
expose ifnet to outside we can eliminate IFNET_HOLD and two
step index allocation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43138
Build 40026: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 4 2021, 9:13 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptDec 4 2021, 9:13 PM

glebius requested review of this revision.Dec 4 2021, 9:13 PM

Harbormaster completed remote builds in B43138: Diff 99447.Dec 4 2021, 9:14 PM

glebius added a child revision: D33260: ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex.Dec 4 2021, 9:15 PM

Apart from the suggestion this looks fine.

sys/net/if.c
636	idx here could right away be ifp->ifindex like it is done in if_vmove() further down and then the new "assignment" in ifnet_setbyindex() doesn't have to be there either as it is not related to that function (it is the reverse).

bz mentioned this in D33260: ifnet: use ck_pr(3) store & load setting ifnet pointer in ifindex.Dec 5 2021, 5:52 PM

glebius added inline comments.Dec 5 2021, 5:56 PM

sys/net/if.c
636	That's what next revisions do. Collapse ifindex_alloc, ifnet_setbyindex and if_grow.

kp accepted this revision as: kp.Dec 6 2021, 10:47 AM

This revision is now accepted and ready to land.Dec 6 2021, 10:47 AM

Closed by commit rG8062e5759cb4: ifnet: allocate index at the end of if_alloc_domain() (authored by glebius). · Explain WhyDec 6 2021, 5:33 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG8062e5759cb4: ifnet: allocate index at the end of if_alloc_domain().

zlei added a commit: rG7afcdd13a49c: ifnet: allocate index at the end of if_alloc_domain().Thu, Oct 10, 10:03 AM

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

38 lines

Diff 99447

View Options

ifnet: allocate index at the end of if_alloc_domain()ClosedPublicActions