security/p5-Crypt-JWT: Update to 0.034
ClosedPublic
Actions

Authored by driesm on Nov 30 2021, 6:32 PM.

Details

Reviewers

0mp
philip

Commits

R11:9af3ecace132: security/p5-Crypt-JWT: Update to 0.034
R11:552c9a7e7338: security/p5-Crypt-JWT: Update to 0.034

Summary

security/p5-Crypt-JWT: Update to 0.034

Ensure payload is serialized consistently (canonical).

 PR:			260112
 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33201

Test Plan

Testport looks good.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

driesm created this revision.Nov 30 2021, 6:32 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 30 2021, 6:32 PM

driesm requested review of this revision.Nov 30 2021, 6:32 PM

Harbormaster completed remote builds in B43065: Diff 99256.Nov 30 2021, 6:32 PM

Is this a candidate to merge quarterly? If I recall correctly, security and bug fixes can be MFC-ed to quarterly?

Approved by: philip (mentor)

Yes: this can be merged to quarterly.

This revision is now accepted and ready to land.Dec 1 2021, 2:04 AM

Closed by commit R11:552c9a7e7338: security/p5-Crypt-JWT: Update to 0.034 (authored by svysh.fbsd_gmail.com, committed by driesm). · Explain WhyDec 1 2021, 1:44 PM

This revision was automatically updated to reflect the committed changes.

driesm added a commit: R11:552c9a7e7338: security/p5-Crypt-JWT: Update to 0.034.

Do I make a seperate review for the MFH commit to 2021Q4?

No need. If you do the git cherry-pick as described in the handbook, you'll get the same commit on the quarterly branch as on main -- including the Approved by: line. :)

driesm added a commit: R11:9af3ecace132: security/p5-Crypt-JWT: Update to 0.034.Dec 2 2021, 8:33 AM

Great work with the MFH (MFC is for src)!

Two notes:

Remember to test the build on quarterly as well. It happens surprisingly often that trivial patches break for whatever reason when MFH'ed. Although usually less so for Python ports :D
If you know that you are going to MFH then you may add MFH: 2021Q4 to your commit message to let others know about your plans. It is not required (it used to be because you had to receive an approval to MFH) and it is not binding. It's a good practice.

Cheers!