Page MenuHomeFreeBSD
Differential D33162

sys/libkern.h: Add type conversion helpers
ClosedPublic
Actions

Authored by hum_semihalf.com on Nov 29 2021, 12:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 10:23 PM
Unknown Object (File)
Mon, Dec 23, 8:09 AM
Unknown Object (File)
Oct 31 2024, 4:06 PM
Unknown Object (File)
Oct 6 2024, 3:24 PM
Unknown Object (File)
Oct 3 2024, 2:34 PM
Unknown Object (File)
Oct 3 2024, 1:17 PM
Unknown Object (File)
Sep 30 2024, 7:14 PM
Unknown Object (File)
Sep 26 2024, 2:20 PM
View All Files
Subscribers
contact_artur-rojek.eu
fuz
imp
kd

Details

Reviewers
mw
wma
manu
Commits
rGefa5d3831b0f: sys/libkern.h: Add type conversion helpers
Summary

Add helper functions for 32 and 64 bit unsigned to signed integers
conversions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hum_semihalf.com created this revision.Nov 29 2021, 12:29 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 29 2021, 12:29 PM
hum_semihalf.com requested review of this revision.Nov 29 2021, 12:29 PM
hum_semihalf.com added a child revision: D32818: TMP461: Add thermal sensor driver.
fuz added a comment.Nov 29 2021, 12:37 PM

I would prefer shorter names. signed_extend32 is really unwieldy. Also, the name does not really explain that the operation is really about extracting from bitfields.

How about mirroring the ARM instructions these are based on? I.e. sbfx32 and sbfx64.

hum_semihalf.com updated this revision to Diff 99212.Nov 30 2021, 8:44 AM

Change function's names to more self-descriptive, reflecting followed ARM instructions behavior.

manu added a comment.Nov 30 2021, 8:54 AM

sbfx32 means nothing to me, signed_extend32 was way more clear to what it does.

contact_artur-rojek.eu added a comment.Nov 30 2021, 12:24 PM

How about extract_s32/extract_s64?

fuz added a comment.Nov 30 2021, 12:39 PM
In D33162#750038, @contact_artur-rojek.eu wrote:

How about extract_s32/extract_s64?

I like the idea but would reduce it to sextract32 and sextract64. Or just leave the underscore out. Alternative: extractl and extractll (with corresponding unsigned functions extractul and extractull).

This revision was not accepted when it landed; it landed in state Needs Review.Dec 2 2021, 9:00 AM
Closed by commit rGefa5d3831b0f: sys/libkern.h: Add type conversion helpers (authored by hum_semihalf.com, committed by wma). · Explain Why
This revision was automatically updated to reflect the committed changes.
wma added a commit: rGefa5d3831b0f: sys/libkern.h: Add type conversion helpers.
wma added a comment.Dec 2 2021, 9:02 AM

I agree with @manu These functions are going to be used extremely rarely and imo the more meaningful name the better.

Revision Contents
Changeset List

PathSize
sys/
sys/
16 lines

Diff 99140

View Options

sys/sys/libkern.h

Loading...