MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Details
- Reviewers
emaste - Group Reviewers
manpages - Commits
- rGe0189cf66a94: elf.5: Document compressed section headers
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
share/man/man5/elf.5 | ||
---|---|---|
1077 | an Elf64_...? |
I think it'd be nice to get all other functions marked up properly too, unless they're part of display blocks (Bd Ed macros in mdoc).
share/man/man5/elf.5 | ||
---|---|---|
1077 | These are functions and need .Fn in front of them as is documented in mdoc(7). You might also wanna reflow the sentence. | |
1077 |
Nope, it's "a structure" even if it's a specific type of structure. |
share/man/man5/elf.5 | ||
---|---|---|
1077 |
I think he just meant that an a in front of Elf should really be an an. |
share/man/man5/elf.5 | ||
---|---|---|
1077 | Is .Fn correct, or should this be .Vt? |
share/man/man5/elf.5 | ||
---|---|---|
1077 |
No, it's still 'a structure', not 'an structure'. | |
1077 |
Oh, you're right that it's not a function - but is it a variable name (Va) rather than a vatiable type (Vt)? |
share/man/man5/elf.5 | ||
---|---|---|
1077 |
This is really news to me, a Elf structure doesn't sound quite right, but I'm not a native speaker. I guess I'd have to grep some larger corpus of English text for more examples of similar context. |
share/man/man5/elf.5 | ||
---|---|---|
1077 | The correct phrase is 'an Elf64_Chrdr or Elf32_Chrdr structure'. The rule is to use 'a' in front of words that don't start with a vowel sound, and 'an' in front of words that start with a vowel sound. Words further away don't matter. It is the rule I learned in school. I also checked with my wife, who has a masters degree in English and taught college English for a time to confirm this rule. In this case, it's in front of 'Elf' which starts with the 'E' sounds so it should be 'an Elf'. This is true if you say 'elf' or 'ee el eff' for the name of the structure. See also https://www.thesaurus.com/e/grammar/a-vs-an/ or https://www.merriam-webster.com/words-at-play/is-it-a-or-an for two other references that seem credible. |
share/man/man5/elf.5 | ||
---|---|---|
1077 | I agree with everyone saying "an". Consider: |