DIOCKEEPCOUNTERS used to overlap with DIOCGIFSPEEDV0, which has been
fixed in 14, but remains in stable/12 and stable/13.
Support the old, overlapping, call under COMPAT_FREEBSD12.
Details
Details
- Reviewers
jhb - Group Reviewers
network - Commits
- rG8e492101ec04: pf: add COMPAT_FREEBSD13 for DIOCKEEPCOUNTERS
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 42795 Build 39683: arc lint + arc unit
Event Timeline
| sys/netpfil/pf/pf_ioctl.c | ||
|---|---|---|
| 4668 | Given you've merged it to stable/13, I think it probably should be COMPAT_FREEBSD13 and use _FREEBSD13 as the suffix. If we don't have a COMPAT_FREEBSD13 option yet, that can be added in a commit before this one (and I can help with that if needed) | |
Comment Actions
(The option in the commit log still says 12, but I realize if you updated it locally, the phab description doesn't auto-update so this might just be stale in phab)
Comment Actions
That's exactly correct, yes. I updated the commit message locally after pushing the update. In part because git-arc uses the commit message to match commits to reviews.