Page MenuHomeFreeBSD
Differential D32977

iser: Remove redundant linuxkpi MODULE_DEPEND
ClosedPublic
Actions

Authored by khng on Nov 12 2021, 9:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 19, 5:39 PM
Unknown Object (File)
Thu, Sep 19, 11:10 AM
Unknown Object (File)
Wed, Sep 18, 11:52 AM
Unknown Object (File)
Wed, Sep 18, 6:25 AM
Unknown Object (File)
Tue, Sep 17, 9:32 AM
Unknown Object (File)
Mon, Sep 16, 7:47 PM
Unknown Object (File)
Sun, Sep 15, 4:13 AM
Unknown Object (File)
Sun, Sep 15, 4:13 AM
View All 36 Files
Subscribers
imp

Details

Reviewers
trasz
Commits
rG35f26bdf5948: iser: Remove redundant linuxkpi MODULE_DEPEND
rGb0c7681ed739: iser: Remove redundant linuxkpi MODULE_DEPEND
rGf7523c8a19d0: iser: Remove redundant linuxkpi MODULE_DEPEND
Summary

Since ibcore depends on linuxkpi, there is no need to pull in the
linuxkpi dependency in iser.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Nov 12 2021, 9:50 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 12 2021, 9:50 PM
khng requested review of this revision.Nov 12 2021, 9:50 PM
Harbormaster completed remote builds in B42770: Diff 98448.Nov 12 2021, 9:50 PM
khng added a reviewer: trasz.Nov 12 2021, 9:51 PM
trasz added a comment.Nov 13 2021, 2:28 PM

I wonder why it's there in the first place. Does autoloading dependencies (linuxkpi) on kldload iser work without it?

khng added a comment.Nov 13 2021, 5:56 PM
In D32977#744557, @trasz wrote:

I wonder why it's there in the first place. Does autoloading dependencies (linuxkpi) on kldload iser work without it?

Yes, it works by simply kldload iser.

trasz accepted this revision.Nov 14 2021, 4:24 PM
This revision is now accepted and ready to land.Nov 14 2021, 4:24 PM
Closed by commit rGf7523c8a19d0: iser: Remove redundant linuxkpi MODULE_DEPEND (authored by khng). · Explain WhyNov 15 2021, 6:06 AM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rGf7523c8a19d0: iser: Remove redundant linuxkpi MODULE_DEPEND.
khng added a commit: rGb0c7681ed739: iser: Remove redundant linuxkpi MODULE_DEPEND.Nov 24 2021, 8:20 PM
khng added a commit: rG35f26bdf5948: iser: Remove redundant linuxkpi MODULE_DEPEND.

Revision Contents
Changeset List

PathSize
sys/
dev/
iser/
1 line

Diff 98503

View Options

sys/dev/iser/icl_iser.c

Loading...