Page MenuHomeFreeBSD

tcp: Fix a lock leak in tcp_congestion()
AbandonedPublic

Authored by markj on Nov 12 2021, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 21, 4:01 AM
Unknown Object (File)
Mon, Apr 21, 3:59 AM
Unknown Object (File)
Mon, Apr 21, 12:39 AM
Unknown Object (File)
Mon, Apr 21, 12:35 AM
Unknown Object (File)
Mon, Apr 21, 12:09 AM
Unknown Object (File)
Sat, Apr 19, 2:33 AM
Unknown Object (File)
Thu, Apr 17, 1:51 AM
Unknown Object (File)
Wed, Apr 16, 9:39 PM
Subscribers

Details

Reviewers
rrs
tuexen
Group Reviewers
transport
Summary

Fixes: b8d60729deef ("tcp: Congestion control cleanup.")
Reported by: syzbot+b1a888df08efaa7b4bf1@syzkaller.appspotmail.com

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42767
Build 39655: arc lint + arc unit

Event Timeline

markj requested review of this revision.Nov 12 2021, 7:59 PM

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

Incomplete, a better patch is in D32975.

I think CC_LIST_RUNLOCK() must also be called when exiting from the function via INP_WLOCK_RECHECK(). Or am I missing something?I looked also at the issue, and expanded the macros. See D32975.

I can abandon my review, but you would need to change yours.

I think your patch is better.