Page MenuHomeFreeBSD

xen/intr: allow xen_intr_release_isrc() to reuse lock
AbandonedPublic

Authored by ehem_freebsd_m5p.com on Nov 7 2021, 4:25 AM.
Tags
None
Referenced Files
F102563884: D32877.diff
Thu, Nov 14, 2:59 AM
Unknown Object (File)
Oct 8 2024, 11:55 AM
Unknown Object (File)
Oct 5 2024, 10:59 AM
Unknown Object (File)
Oct 5 2024, 8:33 AM
Unknown Object (File)
Oct 5 2024, 2:04 AM
Unknown Object (File)
Oct 2 2024, 8:19 PM
Unknown Object (File)
Oct 2 2024, 9:24 AM
Unknown Object (File)
Sep 30 2024, 9:20 AM
Subscribers

Details

Reviewers
royger
mhorne
Summary

Calling mtx_unlock() only to immediately call mtx_lock() isn't so great.
Since xen_intr_unbind() already has the main lock held before calling
xen_intr_release_isrc(), avoid the back to back unlock then lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42640
Build 39528: arc lint + arc unit

Event Timeline

Kind of a "Hey, look what D32876 allows us to do!"

Yes, this got into Phabricator before final testing. Indeed, it is broken. The fix is pretty obvious.

Upon examination I suspect things may head in a different direction.

This isn't even the slightest bit of a priority. Worse, this does indeed make locking harrier.