Differential D32841

ktls: Add tests for sending empty fragments for TLS 1.0 connections.
ClosedPublic
Actions

Authored by jhb on Nov 5 2021, 12:03 AM.

Tags

None

Referenced Files

	F109101793: D32841.diff
	Fri, Jan 31, 7:35 PM

	Unknown Object (File)
	Sun, Jan 26, 7:08 AM

	Unknown Object (File)
	Fri, Jan 24, 5:31 PM

	Unknown Object (File)
	Thu, Jan 23, 6:56 PM

	Unknown Object (File)
	Thu, Jan 23, 10:16 AM

	Unknown Object (File)
	Sat, Jan 18, 9:45 PM

	Unknown Object (File)
	Fri, Jan 17, 11:43 PM

	Unknown Object (File)
	Sun, Jan 12, 6:01 PM

View All 65 Files

Subscribers

Details

Reviewers

Commits

rG27d29db0fa81: ktls: Add tests for sending empty fragments for TLS 1.0 connections.
rG0ff2a12ae32a: ktls: Add tests for sending empty fragments for TLS 1.0 connections.

Summary

Sponsored by: Netflix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42591
Build 39479: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 5 2021, 12:03 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2021, 12:03 AM

jhb requested review of this revision.Nov 5 2021, 12:03 AM

jhb added a parent revision: D32840: ktls: Add padding tests for AES-CBC MTE cipher suites..

Harbormaster completed remote builds in B42591: Diff 98039.Nov 5 2021, 12:03 AM

jhb added a child revision: D32842: ktls: Reject some invalid cipher suites..Nov 5 2021, 12:04 AM

markj accepted this revision.Nov 13 2021, 2:42 AM

markj added inline comments.

tests/sys/kern/ktls_test.c
948	Why assert() rather than ATF_REQUIRE?

This revision is now accepted and ready to land.Nov 13 2021, 2:42 AM

jhb added inline comments.Nov 15 2021, 7:22 PM

tests/sys/kern/ktls_test.c
948	I did this earlier in the control transmit test I had copied this from mostly. In this case I guess I was viewing an assert as meaning I had done something wrong, but perhaps these should be ATF_REQUIRE instead as it is validating data generated by the kernel.

jhb marked an inline comment as done.Nov 15 2021, 7:28 PM

Closed by commit rG0ff2a12ae32a: ktls: Add tests for sending empty fragments for TLS 1.0 connections. (authored by jhb). · Explain WhyNov 15 2021, 8:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0ff2a12ae32a: ktls: Add tests for sending empty fragments for TLS 1.0 connections..

jhb added a commit: rG27d29db0fa81: ktls: Add tests for sending empty fragments for TLS 1.0 connections..Nov 23 2021, 11:14 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

85 lines

Diff 98039

tests/sys/kern/ktls_test.c

Loading...