Page MenuHomeFreeBSD

if_gif: fix vnet shutdown panic
ClosedPublic

Authored by kp on Nov 4 2021, 5:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 14, 6:18 AM
Unknown Object (File)
Tue, Sep 10, 4:08 PM
Unknown Object (File)
Sat, Sep 7, 4:41 PM
Unknown Object (File)
Fri, Sep 6, 10:13 AM
Unknown Object (File)
Thu, Sep 5, 10:06 PM
Unknown Object (File)
Thu, Sep 5, 10:48 AM
Unknown Object (File)
Jul 13 2024, 1:51 PM
Unknown Object (File)
Jul 2 2024, 10:00 PM

Details

Summary

If an if_gif exists and has an address assigned inside a vnet when the
vnet is shut down we failed to clean up the address, leading to a panic
when we ip_destroy() and the V_in_ifaddrhashtbl is not empty.

This happens because of the VNET_SYS(UN)INIT order, which means we
destroy the if_gif interface before the addresses can be purged (and
if_detach() does not remove addresses, it assumes this will be done by
the stack teardown code).

Set subsystem SI_SUB_PSEUDO just like if_bridge so the cleanup
operations happen in the correct order.

MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable