DP83867 is a 10/100/1000 Texas Instruments PHY.
Only SGMII mode is supported.
Link status changes can be checked through an interrupt generated by the PHY if available
Details
- Reviewers
mw wma - Commits
- rGe85c94b8d6ca: Introduce DP83867 PHY driver
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
I'd like to test this review, but two errors occured when building. First one, unknown function 'device_get_property' means I need fresh sources (I see it in recently fetched git repository).
Second one, no member named 'mii_maxspeed' in 'struct mii_softc' I can't resolve recently - looking into file sys/dev/mii/miivar.h, where struct mii_softc is defined, does not show such member of structure.
Looking a bit more into it, I think maxspeed variable and mii_maxspeed struct member is just read from DTB, but not used anywhere.
After some mail exchange regarding problem elsewhere, applied this review minus maxspeed handling for brevity, DP83867 PHY looks like working for me (I need to fix something else unrelated to this review to be sure) - at least media status sense and autonegotiation works as expected.