blackhole(4): disable for locally originated TCP/UDP packets

[glebius]

Summary

In most cases blackholing for locally originated packets is undesired,
leads to different kind of lags and delays. Provide sysctls to enforce
it, e.g. for debugging purposes.

[rrs]

sys/netinet/tcp_input.c

147

A boolean should have two values "true" and "false". Yet you use this
V_blackhole =1 or V_blackhole = 2

I think you need to change it back to an int since its used with multiple values.

[glebius]

sys/netinet/tcp_input.c

147

My boolean is V_blackhole_local. The V_blackhole remains int as it was.

[tuexen]

Does it make sense to add some text to the blackhole man-page? Once this is in the tree, I can add the corresponding change for SCTP...

sys/netinet/tcp_input.c

147

He uses V_blackhole_local only as a boolean variable. This variable is different from V_blackhole.

[rrs]

sys/netinet/tcp_input.c

147

ahh I see.. got confused by the variables :)