bhyve: fix incorrect Slot1 Read Only setting in NVMe controller.

[wanpengqian_gmail.com]

Summary

The setting of Read-only firmware slot is incorrect.

Signed-off-by: Wanpeng Qian <[e-mail]>

Test Plan

Within FreeBSD/Linux guest, Identify NVMe controller to check the result.

[wanpengqian_gmail.com]

Can anyone help this patch be committed to HEAD?

[chuck]

usr.sbin/bhyve/pci_nvme.c

471

The emulation does not support Firmware Download/Commit, and thus, it should not advertise this capability.

[wanpengqian_gmail.com]

usr.sbin/bhyve/pci_nvme.c

471

You are right. This bit shouldn't be set.
When I test this with nvmecontrol, I saw the follwing code in nvmecontrol/identify_ext.c

	printf("Firmware Slot 1 Read-Only:   ");
	if (fw != 0)
		printf("%s\n", fw_slot1_ro ? "Yes" : "No");
	else
		printf("N/A\n");

Apparently If we didn't set OACS firmware bit, the nvmecontrol will not print the ReadOnly attribute.
I will submit a change for nvmecontrol.

[wanpengqian_gmail.com]

remove incorrect oacs setting.