bhyve: Fix the wrong Number of Power States Support value also set a reasonable Max Power for NVMe controller

[wanpengqian_gmail.com]

Summary

Number of Power States Support is a 0's based value.
0 indicate 1 power state.

This patch will set 1 power state, also set the Max Power to 10 Watts.
(Max Power Scale is 0, means 0.01 Watts based)

Signed-off-by: Wanpeng Qian <[e-mail]>

Test Plan

Within FreeBSD/Linux guests, list the number of power states and check the Max Power value.

[markj]

Looks ok. I'd explicitly initialize MXPS and NOPS to zero as well.

[wanpengqian_gmail.com]

explicitly initialize MXPS and NOPS to zero as well

[wanpengqian_gmail.com]

In D32657#749683, @wanpengqian_gmail.com wrote:

explicitly initialize MXPS and NOPS to zero as well

Thank you very much. Now initialize the mps_nops to zero as well.

[markj]

Sorry to nitpick a bit more. Please let me know if you'd like me to commit the change.

usr.sbin/bhyve/pci_nvme.c

553–557

I think the comment should also clarify that the value is zero-indexed, otherwise this line looks wrong.

[wanpengqian_gmail.com]

update comment as suggested.

[wanpengqian_gmail.com]

Yes, please commit this for me. thank you.

[wanpengqian_gmail.com]

Can we merge this patch to HEAD?

[chuck]

Give me a few days to check on some wording in the specification.

[chuck]

After getting some clarification on the wording in the specification (which generated an ECN ...), my preference would be to set NPSS to zero but not report any power state information. I.e. all fields of power_state[0] would be zero. Since pci_nvme_init() uses calloc to allocate the softc (which includes the struct nvme_controller_data), I believe all initialization of cd->power_state can be removed from pci_nvme_init_ctrldata().

[chuck]

I will commit the change to npss but drop the power_state[] changes