vt(4): Connect to teken's TP_SETBELLPD
ClosedPublic
Actions

Authored by imp on Oct 24 2021, 5:56 AM.

Details

Reviewers

glebius
manu
des
mav

Commits

rG534fb4b8aec0: vt(4): Connect to teken's TP_SETBELLPD
rG2533eca1c2b9: vt(4): Connect to teken's TP_SETBELLPD

Summary

Add the glue needed to listen to TP_SETBELLPD which tekken uses to
inform its client drivers about the results of parsing
\e[=<pitch>;<duration>B. It converts these to a Hz value for the
tone/pitch of the bell and a duration in ms. There's some loss of
precision because <pitch> in the escape seuquence is defined to be
(1193182 / pitch) Hz and <duration> is in 10ms units. Also note that
kbdcontrol also parses 'off' but then doesn't send the proper escape
sequence, leading me to wonder if that's another bug since tekken
appears to parse that sequence properly and I've added code here to
treat that as the same as quiet or disabled.

In general, Hz from 100 to 2000 is good. Outside that range is possible,
but even at 100Hz the square wave is starting to sound bad and above
2000Hz the speaker may not respond.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 24 2021, 5:56 AM

imp created this revision.

Harbormaster completed remote builds in B42328: Diff 97348.Oct 24 2021, 5:56 AM

imp added a parent revision: D32619: sysbeep: Adjust interface to take a duration as a sbt.Oct 24 2021, 5:56 AM

imp edited the test plan for this revision. (Show Details)Oct 24 2021, 5:58 AM

imp added reviewers: glebius, manu, des.

tsoome added a subscriber: tsoome.Oct 24 2021, 6:14 AM

tsoome added inline comments.

sys/dev/vt/vt.h
311	not quite sure about the variable use?:) or why (?) in comment?

Pardon my ignorance, what applications are known to configure terminal with TP_SETBELLPD?

In D32620#736790, @glebius wrote:

Pardon my ignorance, what applications are known to configure terminal with TP_SETBELLPD?

It's not something an application does directly through a call program call.

This is an intenral teken signal to its driver. It's only done when it parses a certain escape sequence.
And that escape sequence is only generated by kbdcontrol -b as far as I know.
There's an rc.conf variable that configures this at boot, though.

imp retitled this revision from vt(4): Connect to tekken's TP_SETBELLPD to vt(4): Connect to teken's TP_SETBELLPD.Oct 25 2021, 9:40 PM

imp added inline comments.

sys/dev/vt/vt.h
311	It's a comment about what locks that field. It likely should be removed here since it was from when I'd mistakenly added it elsewhere early in development.