route: avoid overlapping strcpy
ClosedPublic
Actions

Authored by kevans on Oct 23 2021, 6:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 18, 1:36 AM

	Unknown Object (File)
	Nov 25 2024, 8:17 PM

	Unknown Object (File)
	Nov 21 2024, 9:41 PM

	Unknown Object (File)
	Oct 19 2024, 5:04 PM

	Unknown Object (File)
	Oct 18 2024, 10:43 AM

	Unknown Object (File)
	Oct 9 2024, 3:53 AM

	Unknown Object (File)
	Oct 7 2024, 5:49 PM

	Unknown Object (File)
	Oct 4 2024, 5:55 AM

View All 39 Files

Subscribers

imp

Details

Reviewers

melifaro
thj
imp
allanjude
emaste

Commits

rG158f319428c1: route: avoid overlapping strcpy

Summary

Passing overlapping buffers to strcpy yields an undefined result, so
let's avoid it. The copy doesn't really need to happen anyways.

This was discovered with _FORTIFY_SOURCE.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Oct 23 2021, 6:55 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 23 2021, 6:55 PM

kevans requested review of this revision.Oct 23 2021, 6:55 PM

Harbormaster completed remote builds in B42322: Diff 97338.Oct 23 2021, 6:55 PM

This should be marginally faster too...

This revision is now accepted and ready to land.Oct 23 2021, 7:10 PM

melifaro accepted this revision.Oct 23 2021, 7:35 PM

kevans mentioned this in D46069: route: avoid overlapping strcpy(3).Jul 23 2024, 6:52 AM

allanjude accepted this revision.Jul 23 2024, 12:22 PM

emaste accepted this revision.Jul 23 2024, 12:47 PM

Closed by commit rG158f319428c1: route: avoid overlapping strcpy (authored by kevans). · Explain WhyJul 23 2024, 8:26 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG158f319428c1: route: avoid overlapping strcpy.

Revision Contents
Changeset List

Path

Size

sbin/

route/

route.c

22 lines

Diff 141291

View Options

route: avoid overlapping strcpyClosedPublicActions