bhyve: do not explicitly map fbuf framebuffer
ClosedPublic
Actions

Authored by corvink on Oct 22 2021, 9:32 AM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 11:32 AM

	Unknown Object (File)
	Fri, Nov 8, 11:32 AM

	Unknown Object (File)
	Thu, Nov 7, 9:50 PM

	Unknown Object (File)
	Wed, Nov 6, 2:59 PM

	Unknown Object (File)
	Wed, Oct 23, 8:29 AM

	Unknown Object (File)
	Wed, Oct 23, 8:28 AM

	Unknown Object (File)
	Wed, Oct 23, 8:28 AM

	Unknown Object (File)
	Wed, Oct 23, 8:24 AM

Subscribers

Details

Reviewers

grehan
manu

Group Reviewers

bhyve

Commits

rGe5fb2bbad268: bhyve: do not explicitly map fbuf framebuffer
rG5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer

Summary

Allocating a BAR will call baraddr which maps the framebuffer. No need
to allocate it explicitly on init.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Oct 22 2021, 9:32 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptOct 22 2021, 9:32 AM

corvink requested review of this revision.Oct 22 2021, 9:32 AM

Works fine.

Was this a general fix, or part of some larger future work ?

This revision is now accepted and ready to land.Oct 25 2021, 11:57 AM

Just a general fix.

corvink added a reviewer: manu.Nov 17 2021, 11:26 AM

Closed by commit rG5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer (authored by corvink, committed by manu). · Explain WhyNov 18 2021, 3:29 PM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG5085153ae4d5: bhyve: do not explicitly map fbuf framebuffer.

manu added a commit: rGe5fb2bbad268: bhyve: do not explicitly map fbuf framebuffer.Jan 14 2022, 2:21 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_fbuf.c

32 lines

Diff 98695

View Options

bhyve: do not explicitly map fbuf framebufferClosedPublicActions