pf: ensure we have the correct source/destination IP address in ICMP errors
ClosedPublic
Actions

Authored by kp on Oct 20 2021, 8:12 AM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG59264e60e1e9: pf: ensure we have the correct source/destination IP address in ICMP errors
rGa50876f0ac7a: pf: ensure we have the correct source/destination IP address in ICMP errors
rGab238f14544b: pf: ensure we have the correct source/destination IP address in ICMP errors

Summary

When we route-to a packet that later turns out to not fit in the
outbound interface MTU we generate an ICMP error.
However, if we've already changed those (i.e. we've passed through a NAT
rule) we have to undo the transformation first.

Obtained from: pfSense
MFC after: 3 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 20 2021, 8:12 AM

Herald added subscribers: melifaro, farrokhi, imp. · View Herald TranscriptOct 20 2021, 8:12 AM

kp requested review of this revision.Oct 20 2021, 8:12 AM

Harbormaster completed remote builds in B42264: Diff 97156.Oct 20 2021, 8:12 AM

kp added a child revision: D32572: pf tests: test NAT-ed ICMP errors.Oct 20 2021, 8:13 AM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 22 2021, 8:57 AM

Closed by commit rGab238f14544b: pf: ensure we have the correct source/destination IP address in ICMP errors (authored by loos, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGab238f14544b: pf: ensure we have the correct source/destination IP address in ICMP errors.

kp added a commit: rGa50876f0ac7a: pf: ensure we have the correct source/destination IP address in ICMP errors.Nov 13 2021, 11:17 PM

kp added a commit: rG59264e60e1e9: pf: ensure we have the correct source/destination IP address in ICMP errors.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

103 lines

Diff 97276

View Options

pf: ensure we have the correct source/destination IP address in ICMP errorsClosedPublicActions