Pass the ACPI ID when reading the ACPI domain
ClosedPublic
Actions

Authored by andrew on Oct 18 2021, 10:39 AM.

Details

Reviewers

dch
kevans
manu
imp

Group Reviewers

arm64

Commits

rGaa3b5d79b2ac: Pass the ACPI ID when reading the ACPI domain
rG4fb002805e0d: Pass the ACPI ID when reading the ACPI domain

Summary

The ACPI ID may not be the same as the FreeBSD CPU id. Use the former
when finding the CPU domain as there is no requirement for it to be
identical to the latter.

Reported by: dch, kevans

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Oct 18 2021, 10:39 AM

Herald added a reviewer: manu. · View Herald TranscriptOct 18 2021, 10:39 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 18 2021, 10:39 AM

Harbormaster completed remote builds in B42223: Diff 97045.Oct 18 2021, 10:39 AM

andrew retitled this revision from Use pass the ACPI ID when reading the ACPI domain to Pass the ACPI ID when reading the ACPI domain.Oct 18 2021, 11:01 AM

Looks good to me. Any other places we make this mistake?

This revision is now accepted and ready to land.Oct 18 2021, 2:14 PM

Use the correct UID value

This revision now requires review to proceed.Oct 18 2021, 3:01 PM

Harbormaster completed remote builds in B42233: Diff 97070.Oct 18 2021, 3:01 PM

This one boots fine here, and acpi uid is consistent with what we're adding in acpi_pxm.c (thanks!)

This revision is now accepted and ready to land.Oct 18 2021, 3:12 PM

Closed by commit rG4fb002805e0d: Pass the ACPI ID when reading the ACPI domain (authored by andrew). · Explain WhyOct 20 2021, 10:02 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG4fb002805e0d: Pass the ACPI ID when reading the ACPI domain.

andrew added a commit: rGaa3b5d79b2ac: Pass the ACPI ID when reading the ACPI domain.Dec 14 2021, 11:08 AM

andrew added a reverting change: rGd33bf8c50bd7: Stop using the kmem for PCPU memory on arm64.Apr 27 2022, 2:25 PM