Page MenuHomeFreeBSD

uma: Fix handling of reserves in zone_import()
ClosedPublic

Authored by markj on Oct 15 2021, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 2:29 PM
Unknown Object (File)
Oct 1 2024, 7:45 PM
Unknown Object (File)
Sep 27 2024, 11:46 AM
Unknown Object (File)
Sep 23 2024, 8:15 AM
Unknown Object (File)
Sep 18 2024, 3:01 AM
Unknown Object (File)
Sep 17 2024, 1:27 PM
Unknown Object (File)
Sep 17 2024, 2:56 AM
Unknown Object (File)
Sep 5 2024, 4:05 AM
Subscribers

Details

Summary

Kegs with no items reserved have uk_reserve = 0. So the check
keg->uk_reserve >= dom->ud_free_items will be true once all slabs are
depleted. Then, rather than go and allocate a fresh slab, we return.

The intent was to do this only when the keg actually has a reserve, so
modify the check to verify this first. Another approach would be to
make uk_reserve signed and set it to -1 until uma_zone_reserve() is
called, but requires a few casts elsewhere.

The bug would cause us to go to the keg more often than necessary when
filling buckets. In a steady state I wouldn't expect it to make much of
a difference, but maybe I'm missing something. I noticed the problem by
code inspection.

Fixes: 1b2dcc8c54a8 ("uma: Avoid depleting keg reserves when filling a bucket")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable