Page MenuHomeFreeBSD
Differential D32514

rtld_malloc: more accurate handling of mmap(2) failure
ClosedPublic
Actions

Authored by kib on Oct 15 2021, 9:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:40 AM
Unknown Object (File)
Fri, Nov 1, 1:07 PM
Unknown Object (File)
Sat, Oct 26, 7:25 AM
Unknown Object (File)
Wed, Oct 23, 5:11 PM
Unknown Object (File)
Wed, Oct 23, 5:11 PM
Unknown Object (File)
Wed, Oct 23, 5:11 PM
Unknown Object (File)
Wed, Oct 23, 5:00 PM
Unknown Object (File)
Fri, Oct 18, 10:33 AM
View All 72 Files
Subscribers
bdragon
imp

Details

Reviewers
arichardson
Commits
rG73dddffc3175: crt_malloc: more accurate handling of mmap(2) failure
Summary

Reset both pagepool_start and pagepool_end after a mmap(2) failure, to avoid using invalid pagepool either for allocation or munmap(2).

PR: 259076
Noted by: Denis Koreshkov <dynamic-wind@mail.ru>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Oct 15 2021, 9:37 PM
Herald added subscribers: bdragon, imp. · View Herald TranscriptOct 15 2021, 9:37 PM
kib requested review of this revision.Oct 15 2021, 9:37 PM
arichardson accepted this revision.Oct 18 2021, 8:16 PM
This revision is now accepted and ready to land.Oct 18 2021, 8:16 PM
arichardson added inline comments.Oct 18 2021, 8:17 PM
libexec/rtld-elf/rtld_malloc.c
285

Use NULL instead of zero?

Closed by commit rG73dddffc3175: crt_malloc: more accurate handling of mmap(2) failure (authored by kib). · Explain WhyOct 18 2021, 10:04 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG73dddffc3175: crt_malloc: more accurate handling of mmap(2) failure.

Revision Contents
Changeset List

PathSize
libexec/
rtld-elf/
8 lines

Diff 97086

View Options

libexec/rtld-elf/rtld_malloc.c

Loading...