Page MenuHomeFreeBSD

pfctl: delay label macro expansion until after rule optimisation
ClosedPublic

Authored by kp on Oct 13 2021, 8:03 PM.
Tags
None
Referenced Files
F96070489: D32488.diff
Mon, Sep 23, 2:32 PM
Unknown Object (File)
Sat, Sep 21, 6:15 AM
Unknown Object (File)
Sat, Sep 21, 2:19 AM
Unknown Object (File)
Thu, Sep 19, 12:00 PM
Unknown Object (File)
Sun, Sep 15, 9:24 PM
Unknown Object (File)
Sat, Sep 14, 11:36 AM
Unknown Object (File)
Sun, Sep 8, 3:42 PM
Unknown Object (File)
Thu, Sep 5, 11:23 AM
Subscribers

Details

Summary

We used to expand the $nr macro in labels into the rule number prior to
the optimisation step. This would occasionally produce incorrect rule
numbers in the labels.

Delay all macro expansion until after the optimisation step to ensure
that we expand the correct values.

MFC after: 1 week
Reported by: Özkan KIRIK <ozkan.kirik@gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 42129
Build 39017: arc lint + arc unit