crt_malloc: Be more persistent when handling mmap() failure
ClosedPublic
Actions

Authored by kib on Oct 12 2021, 9:48 PM.

Details

Reviewers

arichardson
markj

Commits

rG19e008e7f79c: crt_malloc: Be more persistent when handling mmap() failure
rG0b72d2965d68: crt_malloc: use uintptr_t instead of long for arithmetic on addresses

Summary

In the situation with limited address space, together with
fragmentation, it is possible for mmap() request in morecore() to fail
when asking for required size + NPOOLPAGES, but succeed without the
addend.  Retry allocation there.

PR:     259076
Reported by:    Denis Koreshkov <dynamic-wind@mail.ru>

Also

crt_malloc: use uintptr_t instead of long for arithmetic on addresses

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 12 2021, 9:48 PM

Herald added subscribers: bdragon, imp. · View Herald TranscriptOct 12 2021, 9:48 PM

kib requested review of this revision.Oct 12 2021, 9:48 PM

LGTM. roundup2 usage can be simplified but feel free to ignore that suggestion.

libexec/rtld-elf/rtld_malloc.c
262	roundup2 is now type-preserving, so you should be able to pass a caddr_t argument.

This revision is now accepted and ready to land.Oct 12 2021, 10:17 PM

Closed by commit rG0b72d2965d68: crt_malloc: use uintptr_t instead of long for arithmetic on addresses (authored by kib). · Explain WhyOct 12 2021, 11:46 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG0b72d2965d68: crt_malloc: use uintptr_t instead of long for arithmetic on addresses.

kib added a commit: rG19e008e7f79c: crt_malloc: Be more persistent when handling mmap() failure.

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld_malloc.c

6 lines

Diff 96768

View Options

libexec/rtld-elf/rtld_malloc.c

crt_malloc: Be more persistent when handling mmap() failureClosedPublicActions