linuxkpi: Handle NULL cache pointer in kmem_cache_destroy()
ClosedPublic
Actions

Authored by markj on Oct 6 2021, 3:36 PM.

Details

Reviewers

bz
emaste

Group Reviewers

linuxkpi

Commits

rGa76de17715ab: linuxkpi: Handle a NULL cache pointer in kmem_cache_destroy()

Summary

This scenario arose when testing iwlwifi, when iwl_trans_pcie_alloc()
fails at the "wrong" point. Linux handles a NULL pointer here, so let's
do the same.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 6 2021, 3:36 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptOct 6 2021, 3:36 PM

markj requested review of this revision.Oct 6 2021, 3:36 PM

Harbormaster completed remote builds in B41983: Diff 96345.Oct 6 2021, 3:36 PM

emaste accepted this revision.Oct 6 2021, 4:22 PM

emaste added inline comments.

sys/compat/linuxkpi/common/src/linux_slab.c
196	We're already using `unlikely()s` here, maybe add it on this test?

This revision is now accepted and ready to land.Oct 6 2021, 4:22 PM

If you have a log from iwlwifi along with hardware information please email that over as well.

markj added inline comments.Oct 6 2021, 6:49 PM

sys/compat/linuxkpi/common/src/linux_slab.c
196	It really doesn't make sense here, this function is very expensive and rarely called.

Closed by commit rGa76de17715ab: linuxkpi: Handle a NULL cache pointer in kmem_cache_destroy() (authored by markj). · Explain WhyOct 6 2021, 6:51 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa76de17715ab: linuxkpi: Handle a NULL cache pointer in kmem_cache_destroy().

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

linux_slab.c

3 lines

Diff 96363

View Options

sys/compat/linuxkpi/common/src/linux_slab.c

linuxkpi: Handle NULL cache pointer in kmem_cache_destroy()ClosedPublicActions