Differential D32333

e1000: print EEPROM/NVM/OROM versions
ClosedPublic
Actions

Authored by kbowling on Oct 6 2021, 12:45 AM.

Tags

None

Referenced Files

	F102558963: D32333.id96317.diff
	Thu, Nov 14, 1:35 AM

	Unknown Object (File)
	Mon, Nov 11, 4:46 AM

	Unknown Object (File)
	Thu, Oct 17, 6:03 PM

	Unknown Object (File)
	Thu, Oct 17, 6:02 PM

	Unknown Object (File)
	Thu, Oct 17, 6:02 PM

	Unknown Object (File)
	Thu, Oct 17, 6:02 PM

	Unknown Object (File)
	Thu, Oct 17, 6:02 PM

	Unknown Object (File)
	Thu, Oct 17, 6:02 PM

View All 96 Files

Subscribers

Details

Reviewers

gallatin
grehan

Group Reviewers

Intel Networking

Commits

rGc60b5d477cb4: e1000: print EEPROM/NVM/OROM versions
rG38d7f1c5b391: e1000: Lock nvm print sysctl
rG73922769f0c2: e1000: print EEPROM/NVM/OROM versions
rG884b89510faa: e1000: Lock nvm print sysctl
rG293663f4da9e: e1000: print EEPROM/NVM/OROM versions
rG9b3e252e59c6: e1000: Lock nvm print sysctl

Summary

Similar to ixgbe, this is useful for diagnosing problems. In particular, the errata sheets identify the EEPROM version for many fixes.

Test Plan

82579LM:
em0: EEPROM V0.13-4

i219 (2) SPT:
em0: EEPROM V0.8-3

i210:
igb0: EEPROM V3.25-0 eTrack 0x800005cc

i350:
igb0: EEPROM V1.63-0 eTrack 0x800009fb

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Oct 6 2021, 12:45 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 6 2021, 12:46 AM

kbowling requested review of this revision.Oct 6 2021, 12:46 AM

kbowling updated this revision to Diff 96317.Oct 6 2021, 1:53 AM

gallatin accepted this revision.Oct 6 2021, 12:53 PM

gallatin added inline comments.

sys/dev/e1000/if_em.c
4506	If it was me, I'd probably print something like "NVM version unknown"

This revision is now accepted and ready to land.Oct 6 2021, 12:53 PM

kbowling updated this revision to Diff 96356.Oct 6 2021, 6:20 PM

kbowling edited the test plan for this revision. (Show Details)

This revision now requires review to proceed.Oct 6 2021, 6:20 PM

kbowling updated this revision to Diff 96357.Oct 6 2021, 6:23 PM

kbowling edited the test plan for this revision. (Show Details)

kbowling added inline comments.Oct 6 2021, 6:25 PM

sys/dev/e1000/if_em.c
4636	This will be committed as a separate bug fix, it prevents a KASSERT deep in the shared code

kbowling marked an inline comment as done.Oct 6 2021, 6:27 PM

kbowling updated this revision to Diff 96360.Oct 6 2021, 6:38 PM

@gallatin can you have another look? The locking model on the e1000 is tricky due to the HW so I stashed the info on attach. There's a separate KASSERT fix for em_print_nvm_info for review as well.

kbowling edited the test plan for this revision. (Show Details)Oct 6 2021, 8:43 PM

gallatin accepted this revision.Oct 6 2021, 10:58 PM

This revision is now accepted and ready to land.Oct 6 2021, 10:58 PM

Closed by commit rG9b3e252e59c6: e1000: Lock nvm print sysctl (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyOct 6 2021, 11:24 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG9b3e252e59c6: e1000: Lock nvm print sysctl.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG293663f4da9e: e1000: print EEPROM/NVM/OROM versions.Oct 6 2021, 11:28 PM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG884b89510faa: e1000: Lock nvm print sysctl.Oct 13 2021, 2:12 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG73922769f0c2: e1000: print EEPROM/NVM/OROM versions.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG38d7f1c5b391: e1000: Lock nvm print sysctl.Oct 13 2021, 2:16 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGc60b5d477cb4: e1000: print EEPROM/NVM/OROM versions.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

176 lines

Diff 96317

sys/dev/e1000/if_em.c

Loading...