Page MenuHomeFreeBSD
Differential D32172

loader: set boot_safe=YES when safe mode is selected
ClosedPublic
Actions

Authored by kevans on Sep 28 2021, 3:42 AM.
Tags
None
Referenced Files
F107915950: D32172.diff
Sun, Jan 19, 9:16 AM
Unknown Object (File)
Wed, Jan 15, 4:12 PM
Unknown Object (File)
Sun, Jan 12, 8:02 AM
Unknown Object (File)
Mon, Jan 6, 10:41 AM
Unknown Object (File)
Mon, Jan 6, 7:14 AM
Unknown Object (File)
Mon, Jan 6, 6:51 AM
Unknown Object (File)
Mon, Jan 6, 5:10 AM
Unknown Object (File)
Mon, Jan 6, 2:57 AM
View All 36 Files
Subscribers
dab

Details

Reviewers
allanjude
imp
tsoome
manu
Group Reviewers
manpages
Commits
rG48b05b8fc248: loader: set boot_safe when safe mode is selected
Summary

This may be used to disable or limit functionality of some services
when safe mode is selected.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41800
Build 38689: arc lint + arc unit

Event Timeline

kevans created this revision.Sep 28 2021, 3:42 AM
Herald added a reviewer: manpages. · View Herald TranscriptSep 28 2021, 3:42 AM
Herald added a subscriber: dab. · View Herald Transcript
kevans requested review of this revision.Sep 28 2021, 3:42 AM
Harbormaster completed remote builds in B41797: Diff 95811.Sep 28 2021, 3:42 AM
imp added inline comments.Sep 28 2021, 3:53 AM
stand/man/loader.8
391

Is it set or not? Or does its value matter. I recommend the former and that we document it like that...

kevans added inline comments.Sep 28 2021, 4:05 AM
stand/man/loader.8
391

Hmm, other boot_* style kenv officially check for set + not-"no", but I don't know if that's really common knowledge. I tend to agree with you, though, and I'll amend the documentation to reflect that.

imp added inline comments.Sep 28 2021, 4:52 AM
stand/man/loader.8
391

Yea, , those are just to set rb_howto... this seems different.

kevans updated this revision to Diff 95815.Sep 28 2021, 5:17 AM

Advise that only the presence of a value matters

Harbormaster completed remote builds in B41800: Diff 95815.Sep 28 2021, 5:18 AM
tsoome added a comment.Sep 30 2021, 3:21 PM
In D32172#726049, @kevans wrote:

Advise that only the presence of a value matters

I am a bit confused, nothing seems to check it (boot_safe variable, that is)?

kevans added a comment.Sep 30 2021, 3:43 PM
In D32172#727442, @tsoome wrote:
In D32172#726049, @kevans wrote:

Advise that only the presence of a value matters

I am a bit confused, nothing seems to check it (boot_safe variable, that is)?

Correct, I still need to poke through rc scripts and see if any others besides devmatch might make sense to avoid if boot_safe is set.

tsoome accepted this revision.Sep 30 2021, 4:02 PM
This revision is now accepted and ready to land.Sep 30 2021, 4:02 PM
imp accepted this revision.Sep 30 2021, 7:53 PM
Closed by commit rG48b05b8fc248: loader: set boot_safe when safe mode is selected (authored by kevans). · Explain WhyDec 14 2024, 4:32 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG48b05b8fc248: loader: set boot_safe when safe mode is selected.
Herald added a reviewer: manu. · View Herald TranscriptDec 14 2024, 4:32 AM

Revision Contents
Changeset List

PathSize
stand/
forth/
2 lines
lua/
2 lines
man/
17 lines
17 lines

Diff 95815

View Options

stand/forth/menu-commands.4th

Loading...
View Options

stand/lua/core.lua

Loading...
View Options

stand/man/loader.8

Loading...
View Options

stand/man/loader_simp.8

Loading...