Page MenuHomeFreeBSD
Differential D32131

ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'
ClosedPublic
Actions

Authored by kbowling on Sep 25 2021, 1:44 AM.
Tags
None
Referenced Files
F101942787: D32131.id95694.diff
Tue, Nov 5, 5:00 PM
Unknown Object (File)
Tue, Nov 5, 3:26 PM
Unknown Object (File)
Fri, Oct 25, 4:48 PM
Unknown Object (File)
Sat, Oct 19, 9:28 AM
Unknown Object (File)
Fri, Oct 18, 5:20 AM
Unknown Object (File)
Mon, Oct 14, 10:57 AM
Unknown Object (File)
Oct 5 2024, 10:06 AM
Unknown Object (File)
Oct 4 2024, 7:14 PM
View All 93 Files
Subscribers
ae

Details

Reviewers
jhb
markj
imp
Group Reviewers
Intel Networking
Commits
rG2b81559f4fd6: ixgbe: whitespace cleanup pass
rG90e279aecd64: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'
rG456b1d96e8c4: ixgbe: whitespace cleanup pass
rG4418b03c6759: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'
rG15d077995bd2: ixgbe: whitespace cleanup pass
rGb1d5caf3c750: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'
Summary

Rename the 'struct adapter' to 'struct ixgbe_softc' to avoid type ambiguity in things like kgdb.

Test Plan

Build and run
Visual inspection

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kbowling created this revision.Sep 25 2021, 1:44 AM
Herald added a subscriber: ae. · View Herald TranscriptSep 25 2021, 1:44 AM
kbowling requested review of this revision.Sep 25 2021, 1:44 AM
kbowling added a reviewer: Intel Networking.
kbowling planned changes to this revision.Sep 25 2021, 1:48 AM

Need to fix ixv

kbowling updated this revision to Diff 95696.Sep 25 2021, 2:02 AM
kbowling updated this revision to Diff 95697.Sep 25 2021, 2:06 AM
markj added inline comments.Sep 25 2021, 2:30 PM
sys/dev/ixgbe/ixgbe.h
308

All the indentation here looks strange now. Are you editing with tabstop=4?

kbowling updated this revision to Diff 95737.Sep 25 2021, 6:33 PM

ts=8

kbowling marked an inline comment as done.Sep 25 2021, 6:34 PM
kbowling added inline comments.
sys/dev/ixgbe/ixgbe.h
308

Yes good call!

markj accepted this revision.Sep 26 2021, 3:53 PM

The whitespace changes should be committed separately.

This revision is now accepted and ready to land.Sep 26 2021, 3:53 PM
Closed by commit rGb1d5caf3c750: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc' (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhySep 26 2021, 6:19 PM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGb1d5caf3c750: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG15d077995bd2: ixgbe: whitespace cleanup pass.Sep 26 2021, 6:32 PM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG4418b03c6759: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'.Oct 3 2021, 1:33 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG456b1d96e8c4: ixgbe: whitespace cleanup pass.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG90e279aecd64: ixgbe: Rename 'struct adapter' to 'struct ixgbe_softc'.Oct 3 2021, 5:04 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG2b81559f4fd6: ixgbe: whitespace cleanup pass.

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
186 lines
26 lines
1267 lines
602 lines
296 lines
49 lines
518 lines
2 lines
2 lines
20 lines
8 lines

Diff 95737

View Options

sys/dev/ixgbe/if_bypass.c

Loading...
View Options

sys/dev/ixgbe/if_fdir.c

Loading...
View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...
View Options

sys/dev/ixgbe/if_sriov.c

Loading...
View Options

sys/dev/ixgbe/ix_txrx.c

Loading...
View Options

sys/dev/ixgbe/ixgbe.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_bypass.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_fdir.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_osdep.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_sriov.h

Loading...