Page MenuHomeFreeBSD

ossl: Add support for ETA mode
ClosedPublic

Authored by kd on Sep 24 2021, 11:38 AM.
Tags
None
Referenced Files
F102421769: D32100.diff
Tue, Nov 12, 1:31 AM
Unknown Object (File)
Mon, Oct 14, 9:15 PM
Unknown Object (File)
Oct 4 2024, 11:16 PM
Unknown Object (File)
Oct 3 2024, 8:23 AM
Unknown Object (File)
Oct 1 2024, 10:14 AM
Unknown Object (File)
Sep 30 2024, 4:23 PM
Unknown Object (File)
Sep 27 2024, 7:32 PM
Unknown Object (File)
Sep 19 2024, 12:44 PM
Subscribers

Details

Summary

With the support for AES-CBC we can now handle ETA requests.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kd requested review of this revision.Sep 24 2021, 11:38 AM
kd created this revision.
jhb added inline comments.
sys/crypto/openssl/ossl.c
176

I don't think ETA makes sense for CHACHA20. I would perhaps require sc->has_aes as the only likely candidates for ETA use (AES-CBC, AES-CTR, and AES-XTS) will all need has_aes

This revision is now accepted and ready to land.Nov 4 2021, 9:02 PM

Don't allow for creating ETA sessions witch CHACHA20 used as a cipher.

This revision now requires review to proceed.Nov 5 2021, 8:52 AM
sys/crypto/openssl/ossl.c
176

Good point. Since we have AEAD of CHACH20+POLY1305 you're right that it doesn't make sense to try to use it for ETA.
I inverted part of this logic instead, checking just for sc->has_aes here would still allow someone to create an ETA session with CHACHA20 as the cipher.

This revision is now accepted and ready to land.Nov 5 2021, 5:01 PM
This revision was automatically updated to reflect the committed changes.