Page MenuHomeFreeBSD

cmp: accept SI suffixes for skip1 and skip2
ClosedPublic

Authored by kevans on Sep 23 2021, 5:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 5:07 AM
Unknown Object (File)
Oct 14 2024, 9:49 PM
Unknown Object (File)
Oct 3 2024, 10:04 PM
Unknown Object (File)
Oct 1 2024, 1:47 PM
Unknown Object (File)
Sep 24 2024, 9:18 AM
Unknown Object (File)
Sep 20 2024, 5:12 AM
Unknown Object (File)
Sep 17 2024, 10:16 AM
Unknown Object (File)
Sep 16 2024, 8:31 PM
Subscribers

Details

Summary

This is compatible with GNU cmp.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 23 2021, 10:09 AM
usr.bin/cmp/cmp.1
93

Power of 2 or power of 10?

usr.bin/cmp/tests/cmp_test2.sh
91

This test suggests not SI bot power of 2

imp requested changes to this revision.Sep 23 2021, 12:53 PM

These suffixes are the power-of-two suffixes, not the SI suffixes which are strictly power of 10.

While I don't mind if we accept them as power-of-two, we shouldn't use 'SI' to refer to them.
Of course, we do refer to them incorrectly in that way in expand_number(3).
We use the SI names for the IEE/IEC values.

This revision now requires changes to proceed.Sep 23 2021, 12:53 PM

Maybe just an entry in the bugs section that SI suffixes use the traditional power of 2 values as described in .Xr expand_number 3.

usr.bin/cmp/cmp.1
93

"may also be specified with power of 2 size suffixes."

w

One last minor nit. Thanks for listening.

usr.bin/cmp/cmp.1
182

maybe s/verbiage/phrase/ here makes sense?

This revision is now accepted and ready to land.Sep 23 2021, 8:10 PM
This revision was automatically updated to reflect the committed changes.