Page MenuHomeFreeBSD
Differential D32027

powerpc64: fix loader regression
ClosedPublic
Actions

Authored by luporl on Sep 20 2021, 5:54 PM.
Tags
None
Referenced Files
F96121741: D32027.diff
Mon, Sep 23, 6:32 PM
F96080571: D32027.id.diff
Mon, Sep 23, 3:02 PM
Unknown Object (File)
Sun, Sep 22, 5:16 AM
Unknown Object (File)
Sat, Sep 21, 6:55 AM
Unknown Object (File)
Fri, Sep 20, 1:01 PM
Unknown Object (File)
Thu, Sep 19, 12:31 PM
Unknown Object (File)
Wed, Sep 18, 7:55 AM
Unknown Object (File)
Mon, Sep 16, 7:06 AM
View All 90 Files
Subscribers
dab
imp

Details

Reviewers
jhibbits
tsoome
mhorne
manu
Group Reviewers
PowerPC
Commits
rGed726c3e34d8: powerpc64: fix loader regression
rG680ca739458b: powerpc64: fix loader regression
Summary

After b4cb3fe0e39a, loader started crashing on PowerPC64, with a
Program Exception (700) error. The problem was that archsw was
used before being initialized, with the new mount feature. This
change fixes the issue by initializing archsw earlier, before
setting currdev, that triggers the mount.

Test Plan

Tested on POWER9 VM, booting successfully with both Hash and Radix MMUs.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41606
Build 38495: arc lint + arc unit

Event Timeline

luporl created this revision.Sep 20 2021, 5:54 PM
Herald added subscribers: dab, imp. · View Herald TranscriptSep 20 2021, 5:54 PM
luporl requested review of this revision.Sep 20 2021, 5:54 PM
Harbormaster completed remote builds in B41606: Diff 95390.Sep 20 2021, 5:54 PM
tsoome requested changes to this revision.Sep 20 2021, 6:01 PM

I think, it is still not set early enough; you want to have it set up before we run devsw probes.

This revision now requires changes to proceed.Sep 20 2021, 6:01 PM
luporl updated this revision to Diff 95451.Sep 21 2021, 3:12 PM

Initialize archsw earlier.

Harbormaster completed remote builds in B41621: Diff 95451.Sep 21 2021, 3:12 PM
tsoome accepted this revision.Sep 21 2021, 4:34 PM
This revision is now accepted and ready to land.Sep 21 2021, 4:34 PM
Closed by commit rG680ca739458b: powerpc64: fix loader regression (authored by luporl). · Explain WhySep 21 2021, 8:30 PM
This revision was automatically updated to reflect the committed changes.
luporl added a commit: rG680ca739458b: powerpc64: fix loader regression.
alfredo added a commit: rGed726c3e34d8: powerpc64: fix loader regression.Mar 4 2022, 7:18 PM
Herald added a reviewer: manu. · View Herald TranscriptMar 4 2022, 7:18 PM

Revision Contents
Changeset List

PathSize
stand/
powerpc/
ofw/
22 lines

Diff 95390

View Options

stand/powerpc/ofw/main.c

Loading...