Differential D31999

LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards
ClosedPublic
Actions

Authored by jrtc27 on Sep 17 2021, 12:12 AM.

Details

Reviewers

• hselasky
manu

Commits

rGe79989d8233b: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards
rG8167c92f65bc: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards

Summary

One of the three uses is already guarded; this guards the remaining ones
to support architectures like riscv that do not provide write-combining,
and is needed to build drm-kmod on riscv.

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41558
Build 38447: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Sep 17 2021, 12:12 AM

Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptSep 17 2021, 12:12 AM

jrtc27 requested review of this revision.Sep 17 2021, 12:12 AM

Harbormaster completed remote builds in B41558: Diff 95273.Sep 17 2021, 12:12 AM

manu accepted this revision.Sep 17 2021, 6:06 AM

This revision is now accepted and ready to land.Sep 17 2021, 6:06 AM

Looks good, though writecombine should not be used when it is not supported.

Closed by commit rG8167c92f65bc: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards (authored by jrtc27). · Explain WhyOct 3 2021, 6:38 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG8167c92f65bc: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards.

jrtc27 added a commit: rGe79989d8233b: LinuxKPI: Add more #ifdef VM_MEMATTR_WRITE_COMBINING guards.Oct 10 2021, 1:38 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

io.h

4 lines

page.h

4 lines

Diff 95273

View Options

sys/compat/linuxkpi/common/include/linux/io.h