ppbus: Set the lock for pps interface, update to latest api

[imp]

Summary

Since we take a lock when we enter the ioctl, we need to set driver_mtx
in the pps structure so it can be dropped while sleeping during a call
to timepps_fetch() with a non-zero timeout (PPS_CANWAIT feature).

Sponsored by: Netflix

[• ian]

sys/dev/ppbus/pps.c

148

The code here also needs to indicate it's aware of the new pps abi that allows sharing the driver's mutex by calling pps_init_abi() instead of pps_init(). The code inside the loop below also needs to look like this.

	sc->pps[0].ppscap = PPS_CAPTUREASSERT | PPS_ECHOASSERT;
	sc->sc_pps.driver_abi = PPS_ABI_VERSION;
	sc->sc_pps.driver_mtx = ppb_get_lock(ppbus);
	pps_init_abi(&sc->pps[0]);

[imp]

sys/dev/ppbus/pps.c

148

Thanks Ian! I missed that detail last night. I'll respin.

[imp]

Update with Ian's patch that Criag tested.

[imp]

sys/dev/ppbus/pps.c

148

Done and updated.

others have suggested diffs to me by enclosing them in triple backticks which doesn't steal the review.

[• ian]

I would be a bit more wordy in the commit, something like;

Since we take a lock when we enter the ioctl, we need to set driver_mtx
in the pps structure so it can be dropped while sleeping during a call
to timepps_fetch() with a non-zero timeout (PPS_CANWAIT feature).

[imp]

In D31763#716893, @ian wrote:

I would be a bit more wordy in the commit, something like...

I like it.

[imp]

update