Page MenuHomeFreeBSD
Differential D31555

linux(4): Add support for __WALL wait option bit.
ClosedPublic
Actions

Authored by dchagin on Aug 16 2021, 12:16 PM.
Tags
None
Referenced Files
F103082666: D31555.diff
Wed, Nov 20, 5:28 PM
F103016010: D31555.diff
Tue, Nov 19, 8:52 PM
Unknown Object (File)
Tue, Nov 19, 7:56 AM
Unknown Object (File)
Fri, Nov 15, 12:05 AM
Unknown Object (File)
Thu, Nov 14, 12:13 PM
Unknown Object (File)
Fri, Nov 8, 12:13 AM
Unknown Object (File)
Tue, Nov 5, 3:00 PM
Unknown Object (File)
Tue, Nov 5, 10:59 AM
View All 97 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
Group Reviewers
Linux Emulation
Commits
rG638a0649cf18: linux(4): Add support for __WALL wait option bit.
rGc7ef7c3facaf: linux(4): Add support for __WALL wait option bit.
Summary

As FreeBSD does not have WALL option bit analogue explicitly set all
possible option bits to emulate Linux WALL wait option bit.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41060
Build 37949: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 16 2021, 12:16 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2021, 12:16 PM
dchagin requested review of this revision.Aug 16 2021, 12:16 PM
Harbormaster completed remote builds in B41060: Diff 93745.Aug 16 2021, 12:16 PM
dchagin added a reviewer: Linux Emulation.Aug 16 2021, 12:18 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
emaste added a child revision: D31554: linux(4): Fixup options value validation in linux_waitid()..Aug 16 2021, 3:14 PM
emaste accepted this revision.Aug 16 2021, 3:20 PM
emaste added a subscriber: emaste.

LGTM. My common suggestion, I think the comment about FreeBSD lacking __WALL and emulating it by setting all bits could go in the source.

This revision is now accepted and ready to land.Aug 16 2021, 3:20 PM
dchagin updated this revision to Diff 93776.Aug 16 2021, 7:00 PM

comment added to the implementation

This revision now requires review to proceed.Aug 16 2021, 7:00 PM
Harbormaster completed remote builds in B41078: Diff 93776.Aug 16 2021, 7:00 PM
emaste accepted this revision.Aug 16 2021, 7:22 PM
This revision is now accepted and ready to land.Aug 16 2021, 7:22 PM
Closed by commit rGc7ef7c3facaf: linux(4): Add support for __WALL wait option bit. (authored by dchagin). · Explain WhyMar 31 2022, 5:51 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGc7ef7c3facaf: linux(4): Add support for __WALL wait option bit..
dchagin added a reverting change: rG5326ebfd05c5: linux(4): Revert c7ef7c3 as it's wrong at all..May 11 2022, 6:02 PM
dchagin added a commit: rG638a0649cf18: linux(4): Add support for __WALL wait option bit..Jun 17 2022, 7:41 PM
dchagin added a reverting change: rG0e89b88d1c46: linux(4): Revert c7ef7c3 as it's wrong at all..Jun 17 2022, 7:45 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linux/
5 lines

Diff 93745

View Options

sys/compat/linux/linux_misc.c

Loading...