Page MenuHomeFreeBSD
Differential D31496

ar: diff reduction against ELF Tool Chain
ClosedPublic
Actions

Authored by emaste on Aug 10 2021, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 9:18 AM
Unknown Object (File)
Tue, Jan 21, 9:16 AM
Unknown Object (File)
Sat, Jan 18, 5:36 PM
Unknown Object (File)
Sat, Jan 18, 5:29 PM
Unknown Object (File)
Sat, Jan 18, 4:36 AM
Unknown Object (File)
Sat, Jan 11, 7:28 PM
Unknown Object (File)
Thu, Jan 9, 8:00 AM
Unknown Object (File)
Thu, Jan 9, 7:54 AM
View All 96 Files
Subscribers
cy
imp

Details

Reviewers
markj
Commits
rG6367fd2ccea3: ar: diff reduction against ELF Tool Chain
rGd8ffb451194e: ar: diff reduction against ELF Tool Chain
rG57aaefdceccd: ar: diff reduction against ELF Tool Chain
rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain
Summary
Remove ar_mode_* wrappers and call ar_read_archive / ar_write_archive
directly.

Obtained from:  ELF Tool Chain
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.Aug 10 2021, 11:33 PM
emaste created this revision.
markj added a comment.Aug 11 2021, 2:02 PM

I think we can drop some sysexits.h includes too?

usr.bin/ar/read.c
67–69

Assertion here too.

usr.bin/ar/write.c
69–70

Should be dropped I guess.

351–354

Upstream ar has an assertion about allowed values for type which I think would be worth having.

emaste updated this revision to Diff 93557.Aug 11 2021, 5:30 PM
emaste marked an inline comment as done.

Updates from mark, rebase

markj accepted this revision.Aug 11 2021, 5:31 PM
This revision is now accepted and ready to land.Aug 11 2021, 5:31 PM
Closed by commit rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain (authored by emaste). · Explain WhyAug 11 2021, 11:13 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGd20e9e02db3d: ar: diff reduction against ELF Tool Chain.
emaste added a reverting change: rGc5bf58add0d5: Revert "ar: diff reduction against ELF Tool Chain".Aug 12 2021, 6:27 PM
emaste mentioned this in rG086f09087713: ar: diff reduction against ELF Tool Chain.Aug 13 2021, 2:40 PM
emaste reopened this revision.Aug 13 2021, 3:10 PM
emaste updated this revision to Diff 93649.
emaste edited the summary of this revision. (Show Details)
emaste added a subscriber: cy.

Correct ranlib breakage reported by @cy

emaste added inline comments.Aug 13 2021, 3:12 PM
usr.bin/ar/ar.c
154

This was the mistake - I had ar_read_archive(bsdar, 's') here previously.

markj accepted this revision.Aug 13 2021, 3:14 PM
This revision is now accepted and ready to land.Aug 13 2021, 3:14 PM
Closed by commit rG57aaefdceccd: ar: diff reduction against ELF Tool Chain (authored by emaste). · Explain WhyAug 13 2021, 3:18 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG57aaefdceccd: ar: diff reduction against ELF Tool Chain.
emaste added a commit: rGd8ffb451194e: ar: diff reduction against ELF Tool Chain.Feb 9 2022, 3:26 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 9 2022, 3:26 PM
emaste added a commit: rG6367fd2ccea3: ar: diff reduction against ELF Tool Chain.Feb 9 2022, 4:38 PM

Revision Contents
Changeset List

PathSize
usr.bin/
ar/
48 lines
18 lines
52 lines
34 lines
4 lines
111 lines

Diff 93575

View Options

usr.bin/ar/acpyacc.y

Loading...
View Options

usr.bin/ar/ar.h

Loading...
View Options

usr.bin/ar/ar.c

Loading...
View Options

usr.bin/ar/read.c

Loading...
View Options

usr.bin/ar/util.c

Loading...
View Options

usr.bin/ar/write.c

Loading...