Page MenuHomeFreeBSD

ar: diff reduction against ELF Tool Chain
ClosedPublic

Authored by emaste on Aug 10 2021, 11:33 PM.
Tags
None
Referenced Files
F102378066: D31496.id93649.diff
Mon, Nov 11, 11:07 AM
Unknown Object (File)
Fri, Nov 8, 1:55 AM
Unknown Object (File)
Fri, Nov 8, 1:34 AM
Unknown Object (File)
Fri, Nov 1, 9:07 AM
Unknown Object (File)
Fri, Oct 18, 3:03 PM
Unknown Object (File)
Oct 12 2024, 9:46 AM
Unknown Object (File)
Oct 3 2024, 8:18 AM
Unknown Object (File)
Sep 27 2024, 12:34 PM
Subscribers

Details

Summary
Remove ar_mode_* wrappers and call ar_read_archive / ar_write_archive
directly.

Obtained from:  ELF Tool Chain
Sponsored by:   The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.

I think we can drop some sysexits.h includes too?

usr.bin/ar/read.c
67–69

Assertion here too.

usr.bin/ar/write.c
69–70

Should be dropped I guess.

351–354

Upstream ar has an assertion about allowed values for type which I think would be worth having.

emaste marked an inline comment as done.

Updates from mark, rebase

This revision is now accepted and ready to land.Aug 11 2021, 5:31 PM
This revision was automatically updated to reflect the committed changes.
emaste updated this revision to Diff 93649.
emaste edited the summary of this revision. (Show Details)
emaste added a subscriber: cy.

Correct ranlib breakage reported by @cy

usr.bin/ar/ar.c
154

This was the mistake - I had ar_read_archive(bsdar, 's') here previously.

This revision is now accepted and ready to land.Aug 13 2021, 3:14 PM
This revision was automatically updated to reflect the committed changes.