Differential D31383

Fix undefined pointer arithmetic in fread()
AbandonedPublic
Actions

Authored by arichardson on Aug 2 2021, 2:44 PM.

Details

Reviewers

pfg

Summary

lib/libc/stdio/fread.c:133:10: runtime error: applying zero offset to null pointer

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40806
Build 37695: arc lint + arc unit

Event Timeline

arichardson created this revision.Aug 2 2021, 2:44 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 2 2021, 2:44 PM

arichardson requested review of this revision.Aug 2 2021, 2:44 PM

Harbormaster completed remote builds in B40806: Diff 93120.Aug 2 2021, 2:44 PM

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

This revision is now accepted and ready to land.Aug 2 2021, 3:02 PM

In D31383#707328, @pfg wrote:

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

Ah nice, that avoids the branch inside the loop. Should I apply the NetBSD change instead?

In D31383#707337, @arichardson wrote:

In D31383#707328, @pfg wrote:

Good.

Please also take a look at NetBSD's change 1.23, "Avoid undefined behavior in fread(3)".

Ah nice, that avoids the branch inside the loop. Should I apply the NetBSD change instead?

I think so ... I haven't had time to test the change .. plus they undid it and then redid it in other commits. :-).

Similar patch (D33903) has been committed.

Revision Contents
Changeset List

Path

Size

lib/

libc/

stdio/

fread.c

9 lines

Diff 93120

View Options

Fix undefined pointer arithmetic in fread()AbandonedPublicActions