make buildworld with time logging for each stage
ClosedPublic
Actions

Authored by wosch on Jul 12 2021, 6:02 PM.

Details

Reviewers

jhb
bcr
imp
emaste
brooks

Commits

rG99feb137f5f6: `make buildworld' with time logging for each stage

Summary

For a full description of the issue, please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257141

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wosch created this revision.Jul 12 2021, 6:02 PM

Herald added a subscriber: emaste. · View Herald TranscriptJul 12 2021, 6:02 PM

wosch requested review of this revision.Jul 12 2021, 6:02 PM

wosch retitled this revision from make buildworld with time logging to make buildworld with time logging for each stage.

wosch added reviewers: jhb, bcr, imp, emaste, brooks.Jul 12 2021, 6:16 PM

Would you be so kind as to show (snippets from) sample output with this change? I think having this sort of data available will be quite useful, just curious how it will look in practice.

wosch edited the summary of this revision. (Show Details)Jul 12 2021, 8:46 PM

Sounds like something that should be put in a variabe TIME_ENV ?= time env that way anyone who doesn't want it, or suspects it is causing trouble can TIME_ENV= to disable

new variable TIME_ENV for "time env" commands

In D31154#702761, @sjg wrote:

Sounds like something that should be put in a variabe TIME_ENV ?= time env that way anyone who doesn't want it, or suspects it is causing trouble can TIME_ENV= to disable

Good point, I will update the patch.

space typo

Any comment or objections to the patch? Thanks!

I have no objection

lwhsu added a subscriber: lwhsu.Jul 27 2021, 1:05 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2021, 9:14 AM

Closed by commit rG99feb137f5f6: `make buildworld' with time logging for each stage (authored by wosch). · Explain Why

This revision was automatically updated to reflect the committed changes.

wosch added a commit: rG99feb137f5f6: `make buildworld' with time logging for each stage.

Why is this on by default rather than guarded by a -DWITH_TIME_MAKE? It's clutter that's printed with no context and should not be of relevance to the vast majority of people building FreeBSD.

Also, isn't the output going to vary based on what shell you're using, and possibly what OS if it's not a builtin in your shell? That's not a particularly great experience.