tcpdump: decode packets on pfsync interfaces
ClosedPublic
Actions

Authored by kp on Jul 12 2021, 5:19 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG0daba7847e2e: tcpdump: decode packets on pfsync interfaces
rGff8f8cd982b0: tcpdump: decode packets on pfsync interfaces
rG3f240bdf3652: tcpdump: decode packets on pfsync interfaces

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 40449
Build 37338: arc lint + arc unit

Event Timeline

kp created this revision.Jul 12 2021, 5:19 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2021, 5:19 PM

kp requested review of this revision.Jul 12 2021, 5:19 PM

Harbormaster completed remote builds in B40449: Diff 92105.Jul 12 2021, 5:19 PM

scottl accepted this revision.Jul 13 2021, 4:51 AM

This revision is now accepted and ready to land.Jul 13 2021, 4:51 AM

Should this be upstreamed? Our tcpdump isn't far behind upstream. Merging a newer upstream is pretty straightforward too.

In D31153#701236, @philip wrote:

Should this be upstreamed? Our tcpdump isn't far behind upstream. Merging a newer upstream is pretty straightforward too.

Upstream tcpdump doesn't have pfsync support at all. It was briefly merged back in 2012, but immediately backed out again:

commit 2886b89df644ab24bc93577d3e309962b3aec09d
Author: Guy Harris <gharris@sonic.net>
Date: Wed Feb 29 21:14:50 2012 -0800
Back out DLT_PFSYNC support.

Unfortunately, the DLT_PFSYNC support depends on header files included
from the pfctl command's source tree, and trying to arrange to find that
would be too much trouble.