syr827: add support for matching SYR828 as well (used by GPUs)
AbandonedPublic
Actions

Authored by bz on Jul 7 2021, 10:23 PM.

Details

Reviewers

manu
br

Summary

In addition to the syr827 regulator (0x40) also match the syr828 (0x41).
The latter is used by the GPU on rk3399 SoC and adding it allows us to
control it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40382
Build 37271: arc lint + arc unit

Event Timeline

bz created this revision.Jul 7 2021, 10:23 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 7 2021, 10:23 PM

bz requested review of this revision.Jul 7 2021, 10:23 PM

Harbormaster completed remote builds in B40382: Diff 91956.Jul 7 2021, 10:24 PM

manu accepted this revision.Jul 7 2021, 10:33 PM

This revision is now accepted and ready to land.Jul 7 2021, 10:33 PM

We should switch to pmic/fan53555 driver which already supports it (along with other variants). I seem to have forgotten to do that. Can you test this, please?

In D31103#699773, @mmel wrote:

We should switch to pmic/fan53555 driver which already supports it (along with other variants). I seem to have forgotten to do that. Can you test this, please?

@mmel are you going to do this?

root@:~ # dmesg -a | egrep -E '(fan53555|vdd_gpu)'
fan53555_pmic0: <SYR827 PMIC> at addr 0x80 on iicbus3
fan53555_pmic0: Regulator vdd_cpu_b: voltage: 1000000 uV
fan53555_pmic1: <SYR828 PMIC> at addr 0x82 on iicbus3
fan53555_pmic1: Regulator vdd_gpu: voltage: 1000000 uV
regulator: shutting down vdd_gpu... ok

If you can, do it yourself. My build environment is currently broken. I'm recovering from ZFS metadata corruption, plus ipfw (libalias) wants to divide by zero from time to time... :( Thanks.

In D31103#699841, @mmel wrote:

If you can, do it yourself. My build environment is currently broken. I'm recovering from ZFS metadata corruption, plus ipfw (libalias) wants to divide by zero from time to time... :( Thanks.

sorry to hear. Do we want to add the other pmic providers there as well or just fan53555? Hmm I don't have a rk3288 to test. I'll leave that one to someone else?

imho, only fan53555. And thanks for help.

bz abandoned this revision.Jul 8 2021, 3:20 PM

bz mentioned this in D31112: fan53555: attach to build and switch from syr827.Jul 8 2021, 5:31 PM

bz mentioned this in rGbf3a385217ce: fan53555: attach to build and switch from syr827.Jul 8 2021, 8:20 PM