Page MenuHomeFreeBSD

tcp: fix build for rack/bbr with various combos of INET and INET6 defined
ClosedPublic

Authored by gallatin on Jul 7 2021, 4:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 2:33 AM
Unknown Object (File)
Tue, Oct 29, 12:50 PM
Unknown Object (File)
Tue, Oct 29, 9:47 AM
Unknown Object (File)
Thu, Oct 24, 1:15 PM
Unknown Object (File)
Oct 14 2024, 10:17 AM
Unknown Object (File)
Sep 27 2024, 4:49 PM
Unknown Object (File)
Sep 27 2024, 4:17 AM
Unknown Object (File)
Sep 27 2024, 1:30 AM
Subscribers

Details

Summary

I have my workstation configured to use the alternate TCP stacks (MK_EXTRA_TCP_STACKS=yes). When trying to address a report that my recent ktls commit (28d0a740dd9) broke the NOINET build, I stumbled across the fact that support for NOINET and NOINET6 has rotted in rack and bbr.

This change allows the alternate stacks to build cleanly with GENERIC, LINT-NOINET, LINT-NOINET6 and LINT-NOIP, that's all the combinations of no ip at all, ipv4 and ipv6

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rrs added inline comments.
sys/netinet/tcp_stacks/rack.c
12093

I am concerned that when you init the fsb, without inet/inet6 we still set r_fsb_inited. That may
make sense.. but I wonder if it would be better to *not* set that flag if there is no INET or INET6.

I guess you have tested this and I think such a configuration (no INET or INET6) is just plain stupid
so I guess I am being over nervous.. let those who config a stupid config get what they deserve (stupid
results) :)

This revision is now accepted and ready to land.Jul 7 2021, 4:21 PM
sys/netinet/tcp_stacks/rack.c
12093

I guess the question is: how could this code even run with neither INET nor INET6 compiled in? There would be nothing to call it..

This revision was automatically updated to reflect the committed changes.