Page MenuHomeFreeBSD

Fix building rescue/rescue when sanitizers are enabled
ClosedPublic

Authored by arichardson on Jul 5 2021, 10:51 AM.
Tags
None
Referenced Files
F102063744: D31044.id91873.diff
Thu, Nov 7, 4:14 AM
Unknown Object (File)
Tue, Nov 5, 9:58 AM
Unknown Object (File)
Thu, Oct 17, 6:11 PM
Unknown Object (File)
Wed, Oct 16, 2:12 PM
Unknown Object (File)
Tue, Oct 15, 1:15 AM
Unknown Object (File)
Sun, Oct 13, 5:41 PM
Unknown Object (File)
Fri, Oct 11, 5:42 PM
Unknown Object (File)
Thu, Oct 10, 9:31 AM
Subscribers

Details

Summary

We have to ensure that we don't link any instrumented object files
into rescue as it is a static executable and static binaries can't
use the sanitizer runtime.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40348
Build 37237: arc lint + arc unit

Event Timeline

imp added inline comments.
rescue/rescue/Makefile
117

do you happen to know why ${LIBIPF} fails in this context?

This revision is now accepted and ready to land.Jul 6 2021, 1:15 AM
rescue/rescue/Makefile
117

It was selecting the _pie.a library that has ASAN instrumentation. Actually this might no longer be needed with the
CRUNCH_BUILDOPTS+= MK_PIE=no line above (my initial patch only had NO_SHARED=yes)

This revision now requires review to proceed.Jul 6 2021, 11:05 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2021, 1:30 PM
This revision was automatically updated to reflect the committed changes.