pf: Add DIOCGETSTATESSTATS
AbandonedPublic
Actions

Authored by kp on Jul 5 2021, 10:06 AM.

Details

Reviewers

Group Reviewers

network
pfsense

Summary

Add DIOCGETSTATESSTATS so userspace can get a reasonable estimate of how
much memory will be required to read out the full state tabe (with
DIOCGETSTATESNV).
It returns both the current number of states and an estimate of the size
per state.

Users of the call need to be aware that the number of states
may change between the DOICGETSTATESSTATS and DIOCGETSTATESNV calls.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 40303
Build 37192: arc lint + arc unit

Event Timeline

kp created this revision.Jul 5 2021, 10:06 AM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald TranscriptJul 5 2021, 10:06 AM

kp requested review of this revision.Jul 5 2021, 10:06 AM

Harbormaster completed remote builds in B40287: Diff 91770.Jul 5 2021, 10:06 AM

kp added a child revision: D31042: libpfctl: Implement pfctl_get_states_stats().Jul 5 2021, 10:09 AM

kp added reviewers: network, pfsense.Jul 5 2021, 10:11 AM

This should have an NV suffix.

add NV suffix

This isn't strictly required, because there's no non-nvlist call to distinguish
this one from, but the review feedback suggests there's an implicit
expectation, so add it anyway.

Harbormaster completed remote builds in B40303: Diff 91790.Jul 5 2021, 1:19 PM

mjg accepted this revision.Jul 5 2021, 2:09 PM

This revision is now accepted and ready to land.Jul 5 2021, 2:09 PM

While this improves the present situation it's still unacceptably slow, so I'm going to try a version without nvlist.