Page MenuHomeFreeBSD
Differential D30980

LinuxKPI: add read_poll_timeout()
ClosedPublic
Actions

Authored by bz on Jul 1 2021, 1:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 6 2024, 9:25 PM
Unknown Object (File)
Oct 4 2024, 5:23 AM
Unknown Object (File)
Oct 2 2024, 3:14 PM
Unknown Object (File)
Sep 28 2024, 8:57 AM
Unknown Object (File)
Sep 27 2024, 6:50 PM
Unknown Object (File)
Sep 27 2024, 4:25 PM
Unknown Object (File)
Sep 23 2024, 7:36 PM
Unknown Object (File)
Sep 5 2024, 7:43 AM
View All 98 Files
Subscribers
emaste
• hselasky
imp

Details

Reviewers
• hselasky
Group Reviewers
linuxkpi
Commits
rGfed248a6acb3: LinuxKPI: add read_poll_timeout()
Summary

Add a partial implementation of read_poll_timeout() which I did at
some point last year for rtw88.

MFC after: 10 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jul 1 2021, 1:31 PM
Herald added a subscriber: emaste. · View Herald TranscriptJul 1 2021, 1:31 PM
bz requested review of this revision.Jul 1 2021, 1:31 PM
Harbormaster completed remote builds in B40212: Diff 91614.Jul 1 2021, 1:31 PM
• hselasky added a subscriber: • hselasky.Jul 1 2021, 3:33 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/iopoll.h
42

Should the code use a sleepable delay in case of non-atomic?

• hselasky added a comment.Jul 21 2021, 8:43 AM

Ping. See my comment.

bz added a comment.Jul 21 2021, 10:37 PM
In D30980#703813, @hselasky wrote:

Ping. See my comment.

Sorry, if you need it urgently please feel free to improve/finish the code. I can test quickly if needed. Feel free to push to this review even.

bz updated this revision to Diff 92852.Jul 28 2021, 12:09 PM

Work on feedback from hselasky and try to finish the implementation
based on descriptions found. I probably should go back and see if the
reworked linux/delay.h functions are more suitable now?

Harbormaster completed remote builds in B40712: Diff 92852.Jul 28 2021, 12:09 PM
bz updated this revision to Diff 92853.Jul 28 2021, 12:25 PM

Use usleep_range now so I don't have to deal with pause_sbt()
which probably also wanted the HARDCLOCK hint otherwise.

Harbormaster completed remote builds in B40713: Diff 92853.Jul 28 2021, 12:25 PM
• hselasky added inline comments.Jul 28 2021, 1:14 PM
sys/compat/linuxkpi/common/include/linux/iopoll.h
42

_to -> (_to)

Missing parenthesis.

48

ditto: _us && _early_sleep need parenthesis.

69

ditto.

bz updated this revision to Diff 92857.Jul 28 2021, 1:41 PM

Add missing ().

Harbormaster completed remote builds in B40716: Diff 92857.Jul 28 2021, 1:41 PM
bz marked 4 inline comments as done.Jul 28 2021, 1:42 PM
• hselasky accepted this revision.Jul 28 2021, 2:26 PM
• hselasky added inline comments.
sys/compat/linuxkpi/common/include/linux/iopoll.h
67

Maybe name internal variables with "__" first?

This revision is now accepted and ready to land.Jul 28 2021, 2:26 PM
bz updated this revision to Diff 92862.Jul 28 2021, 3:16 PM

Prefix internal variables with __ even though it should not
make a difference given they are inside a block.

This revision now requires review to proceed.Jul 28 2021, 3:16 PM
Harbormaster completed remote builds in B40718: Diff 92862.Jul 28 2021, 3:16 PM
• hselasky accepted this revision.Jul 28 2021, 3:35 PM
This revision is now accepted and ready to land.Jul 28 2021, 3:35 PM
Closed by commit rGfed248a6acb3: LinuxKPI: add read_poll_timeout() (authored by bz). · Explain WhyJul 28 2021, 4:24 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rGfed248a6acb3: LinuxKPI: add read_poll_timeout().

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
91 lines

Diff 92883

View Options

sys/compat/linuxkpi/common/include/linux/iopoll.h

Loading...