Page MenuHomeFreeBSD

Eliminate p_elf_machine from struct proc.
ClosedPublic

Authored by dchagin on Jun 28 2021, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 11:29 PM
Unknown Object (File)
Wed, Nov 6, 5:30 AM
Unknown Object (File)
Oct 5 2024, 10:14 AM
Unknown Object (File)
Oct 5 2024, 3:09 AM
Unknown Object (File)
Oct 3 2024, 12:47 PM
Unknown Object (File)
Oct 2 2024, 11:15 AM
Unknown Object (File)
Oct 2 2024, 6:03 AM
Unknown Object (File)
Sep 23 2024, 3:09 AM
Subscribers

Details

Summary

Instead of p_elf_machine use machine member of the Elf_Brandinfo which is now
cached in the struct proc at p_elf_brandinfo member.

As p_elf_flags alignment is 8 bytes here is a hole, should I remove p_reserved?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/sys/proc.h
702–703

We do not leave the cruft in system structures (in HEAD), even if it is padding.

This revision is now accepted and ready to land.Jun 28 2021, 5:56 PM
This revision was automatically updated to reflect the committed changes.