Differential D30814

rtwn: make sure to not write in upper bits of txdseq
ClosedPublic
Actions

Authored by avg on Jun 18 2021, 3:00 PM.

Tags

None

Referenced Files

	F108735175: D30814.diff
	Mon, Jan 27, 3:09 PM

	Unknown Object (File)
	Fri, Jan 24, 5:19 PM

	Unknown Object (File)
	Sat, Jan 18, 10:22 PM

	Unknown Object (File)
	Sat, Jan 18, 10:04 PM

	Unknown Object (File)
	Sat, Jan 18, 3:18 AM

	Unknown Object (File)
	Dec 5 2024, 1:08 AM

	Unknown Object (File)
	Nov 8 2024, 7:04 AM

	Unknown Object (File)
	Nov 8 2024, 4:16 AM

View All 60 Files

Subscribers

Details

Reviewers

adrian
avos
bz
kevlo

Commits

rG7544c1d20d8b: rtwn: make sure to not write in upper bits of txdseq

Summary

ni_txseqs is kept as 16-bit counter, but we need to trim the upper four
bits as they may have special meanings for the firware.
For instance, bit 15 enables hardware / firmware generation of sequence
numbers that overrides sequence numbers programmed by the driver.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39974
Build 36863: arc lint + arc unit

Event Timeline

avg created this revision.Jun 18 2021, 3:00 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 18 2021, 3:00 PM

avg requested review of this revision.Jun 18 2021, 3:00 PM

Harbormaster completed remote builds in B39974: Diff 91057.Jun 18 2021, 3:00 PM

avg added reviewers: adrian, avos, bz, kevlo.Jun 18 2021, 3:02 PM

Good catch!

This revision is now accepted and ready to land.Jun 18 2021, 4:11 PM

Closed by commit rG7544c1d20d8b: rtwn: make sure to not write in upper bits of txdseq (authored by avg). · Explain WhyJun 21 2021, 8:07 AM

This revision was automatically updated to reflect the committed changes.

avg added a commit: rG7544c1d20d8b: rtwn: make sure to not write in upper bits of txdseq.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

rtl8192c/

2 lines

Diff 91057

sys/dev/rtwn/rtl8192c/r92c_tx.c

Loading...