Sponsored by: Netflix
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 39959 Build 36848: arc lint + arc unit
Event Timeline
sys/conf/NOTES | ||
---|---|---|
1050 | As a non-native speaker I'm undecided how to parse this. Is it "in order to get smooth response, you should not lower HZ" or "lowering HZ will get you smooth response but you shouldn't do it (possibly because of undesirable side effects)"? I see it is explained later, but maybe this part here could be improved in any case. |
sys/conf/NOTES | ||
---|---|---|
1051 | The default inside a VM is 100, not sure if it makes sense to mention that here, but, the default may be lower than 1000 | |
1235 | Not your change, but there seems to be a strange character here. | |
1245 | It looks like HZ isn't defined in GENERIC etc anymore. sys/kern/subr_param.c has: #ifndef HZ # if defined(__mips__) || defined(__arm__) # define HZ 100 # else # define HZ 1000 # endif # ifndef HZ_VM # define HZ_VM 100 # endif #else # ifndef HZ_VM # define HZ_VM HZ # endif #endif So NOTES should probably say 1000 here. |
sys/conf/NOTES | ||
---|---|---|
1051 | ACK on both these comments. will see if there's some way to make this clearer and more complete. | |
1235 | This is a form feed. | |
1245 | No. This is wrong two ways. |